chore(tests): remove deployment status cycle test covered by cross-service tests - #1923
Open
p-targowicz wants to merge 1 commit into
Open
chore(tests): remove deployment status cycle test covered by cross-service tests#1923p-targowicz wants to merge 1 commit into
p-targowicz wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
p-targowicz
requested review from
merlin-northern and
mzedel
and removed request for
mzedel
June 25, 2026 08:24
p-targowicz
force-pushed
the
QA-1638-remove-duplicate-deployment-service-tests
branch
from
July 14, 2026 12:41
d2505ae to
594f39f
Compare
…rvice tests test_device_deployments_full walked the full downloading→installing→ rebooting→success status cycle using a fake device. The same cycle is already covered by TestDeploymentsStatusUpdate in the cross-service integration tests which also exercises the full service stack. Remove the redundant service-level test. Ticket: QA-1638 Changelog: None Signed-off-by: Patryk Targowicz <patryk.targowicz@northern.tech>
p-targowicz
force-pushed
the
QA-1638-remove-duplicate-deployment-service-tests
branch
from
July 17, 2026 08:11
594f39f to
6d1cd14
Compare
Contributor
|
There was an error syncing branches, see logs for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the deployments acceptance test test_device_deployments_full: the
full device deployment status cycle is covered by the integration:ng Go
runner (TestDeploymentStatusUpdate / TestDeploymentStatusUpdateToGroup in
backend/tests/runner, see #2034), which walks the complete status
progression including the pause substates, verifies deployment statistics
at every step, asserts the mid-cycle re-poll returns the same deployment,
and covers the post-finish success-to-failure override - i.e. every
assertion of the removed test, plus the negative cases (device not in
deployment 404, invalid status 400).
The sibling acceptance tests remain: they own concerns the runner does not
duplicate (internal mongo state checks, artifact-in-use 409, abort
lifecycle, changed-device-type 409 path).
Depends on #2034.