Fix: propagate sslmode env var#5374
Open
ak7991 wants to merge 4 commits into
Open
Conversation
Author
|
Added the propagation of env var as requested. Hey @kartik-mem0, would recommend to add support for directly providing db connection strings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Relates to #5303
Description
Simply propagate the
POSTGRES_SSLMODEenvironment variable to the self-hosted server's database configuration.Specifically, this PR:
server/db.py) to append thesslmodequeryparam whenPOSTGRES_SSLMODEis provided.POSTGRES_SSLMODEinto the defaultpgvectorstore configuration inserver/main.py.This is a focused follow-up to PR #5308 to address the server-side SSL.
Type of Change
Test Coverage
Checked that the generated database connection string correctly appends
?sslmode=require(or other specified modes) when thePOSTGRES_SSLMODEenvironment variable is set, allowing connections to PostgreSQL instances requiring SSL (e.g., hosted/managed Postgres services).Checklist