Skip to content

fix: use dash separator for S3 Vectors entity collection name#5363

Open
PHclaw wants to merge 1 commit into
mem0ai:mainfrom
PHclaw:fix/s3-entities-collection-name
Open

fix: use dash separator for S3 Vectors entity collection name#5363
PHclaw wants to merge 1 commit into
mem0ai:mainfrom
PHclaw:fix/s3-entities-collection-name

Conversation

@PHclaw
Copy link
Copy Markdown

@PHclaw PHclaw commented Jun 4, 2026

Summary

S3 Vectors does not support underscores in index/collection names. When entity linking is triggered during Memory.add(), the hardcoded _{collection_name}_entities separator causes a ValidationException from the S3 API.

Changes

  • Added provider-aware separator: uses - (dash) for s3_vectors provider, keeps _ (underscore) for all other providers
  • Applied to both entity_store property locations in main.py

Testing

Since I don't have S3 Vectors infrastructure, this was verified by code inspection. The fix is minimal and follows the suggestion in the issue.

Fixes #5361

S3 Vectors does not support underscores in index/collection names,
causing ValidationException during batch entity linking. Use dash (-)
as separator for s3_vectors provider while keeping underscore (_) for
all other providers.

Fixes mem0ai#5361
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


PHclaw seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning output to log when calling Memory.add() using s3 vectors backend

2 participants