fix: use dash separator for S3 Vectors entity collection name#5363
Open
PHclaw wants to merge 1 commit into
Open
fix: use dash separator for S3 Vectors entity collection name#5363PHclaw wants to merge 1 commit into
PHclaw wants to merge 1 commit into
Conversation
S3 Vectors does not support underscores in index/collection names, causing ValidationException during batch entity linking. Use dash (-) as separator for s3_vectors provider while keeping underscore (_) for all other providers. Fixes mem0ai#5361
|
PHclaw seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
S3 Vectors does not support underscores in index/collection names. When entity linking is triggered during Memory.add(), the hardcoded _{collection_name}_entities separator causes a ValidationException from the S3 API.
Changes
Testing
Since I don't have S3 Vectors infrastructure, this was verified by code inspection. The fix is minimal and follows the suggestion in the issue.
Fixes #5361