fix: persist telemetry state as utf-8#5336
Open
Ghraven wants to merge 1 commit into
Open
Conversation
|
|
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
encoding="utf-8"._save_state()and_load_state().Problem
The telemetry state file stores JSON text but currently relies on the platform default encoding. On non-UTF-8 systems, state containing non-ASCII operator input, such as onboarding use-case text, can be decoded or written inconsistently.
Before/after
Before:
STATE_PATH.read_text()andSTATE_PATH.write_text(...)used the process default encoding.After: telemetry state JSON is consistently read and written as UTF-8.
Verification
python -m pytest tests/test_server_telemetry.py