Bug 2034168 explicit permission for file access#44328
Open
rebloor wants to merge 4 commits into
Open
Conversation
Contributor
|
Preview URLs (4 pages)
External URLs (1)URL:
(comment last updated: 2026-06-04 23:14:18) |
pepelsbey
requested changes
Jun 4, 2026
Member
pepelsbey
left a comment
There was a problem hiding this comment.
Looks good! Thank you 🙂
Not sure if it’s a technical review or an editorial one (it would be good to separate those), but I have a few suggestions.
rebloor
commented
Jun 4, 2026
Contributor
Author
There was a problem hiding this comment.
@pepelsbey thanks for the feedback. However, this file shouldn't be in this PR, it's in Add use of declarativeNetRequest to the "Intercept HTTP requests" guide #44301 I'm addressed your feedback there and will be removing this file from the PR shortly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses the dev-doc-needed requirements of Bug 2034168 Add explicit permission for file:-access and implement extension.isAllowedFileSchemeAccess()
Changes include:
falsein Firefox (this and new behavior details now in BCD). Other tidy up edits.isAllowedFileSchemeAccessand update permission details regarding private windows forisAllowedIncognitoAccess.Related issues and pull requests
Relating BCD changes in mdn/browser-compat-data#29776