Skip to content

fix: avoid placeholder result for show node list#198

Open
Ariznawlll wants to merge 1 commit into
matrixorigin:mainfrom
Ariznawlll:fix/issue-17598-show-node-list
Open

fix: avoid placeholder result for show node list#198
Ariznawlll wants to merge 1 commit into
matrixorigin:mainfrom
Ariznawlll:fix/issue-17598-show-node-list

Conversation

@Ariznawlll
Copy link
Copy Markdown
Contributor

Summary

  • normalize the empty placeholder ResultSet returned for show node list so mo-tester does not write the internal 1 column marker into generated results
  • bind commands to actual results in run mode so the same normalization is used during comparison
  • skip writing result text in genrs mode when a ResultSet is normalized to no result

Verification

  • JAVA_HOME=$(/usr/libexec/java_home -v 20) PATH="$JAVA_HOME/bin:$PATH" mvn -q -DskipTests jar:jar
  • locally verified a minimal show node list + result_scan(last_query_id()) case: before this fix mo-tester generated ➤ 1[-5,64,0]; after this fix it no longer emits the placeholder 1

Fixes matrixorigin/matrixone#17598

@qodo-code-review
Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: the result of 'show node list' in mo and in bvt is different.

1 participant