test(fileservice): cover streaming disk cache edge cases#24780
Open
LeftHandCold wants to merge 1 commit into
Open
test(fileservice): cover streaming disk cache edge cases#24780LeftHandCold wants to merge 1 commit into
LeftHandCold wants to merge 1 commit into
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
There was a problem hiding this comment.
Pull request overview
Adds new test coverage for streaming disk cache edge cases in pkg/fileservice/s3_fs_test.go, including range reads bypassing prefetch full-object IO merge, read-to-end (-1 size) handling, unexpected EOF, and exclusions in shouldStreamFullObjectToDiskCache for empty ranges, WriterForRead, and ReadCloserForRead.
Changes:
- Add
TestS3FSRangeReadSkipsPrefetchFullObjectIOMergeverifying range reads don't block on in-flight prefetch merges - Add streaming disk cache tests for read-to-end and unexpected EOF behaviors
- Add
TestS3FSShouldStreamFullObjectToDiskCacheExclusionscovering exclusion conditions
fengttt
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests