Skip to content

fix(plan): add POW alias to functionIdRegister#24778

Open
ULookup wants to merge 1 commit into
matrixorigin:3.0-devfrom
ULookup:fix/issue-24439-pow-function-not-supported
Open

fix(plan): add POW alias to functionIdRegister#24778
ULookup wants to merge 1 commit into
matrixorigin:3.0-devfrom
ULookup:fix/issue-24439-pow-function-not-supported

Conversation

@ULookup
Copy link
Copy Markdown
Collaborator

@ULookup ULookup commented Jun 2, 2026

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #24439

What this PR does / why we need it:

The POW(x, y) MySQL alias for POWER(x, y) was not recognized on 3.0-dev because the string "pow" was missing from the functionIdRegister map in function_id.go. The constant POW = 149 and the Power() execution function already existed — only the lookup registration was missing. This one-line fix adds "pow": POW to the register, making the function accessible through the POW() name. A unit test validates the register lookup, and BVT test cases cover uppercase/lowercase/float POW calls.

@qodo-code-review
Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

Copy link
Copy Markdown
Contributor

@aunjgr aunjgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One-line fix — "pow": POW was missing from functionIdRegister while the POW = 149 constant and Power() execution function already existed. Unit test confirms getFunctionIdByName("pow") resolves; BVT covers uppercase/lowercase/float. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Something isn't working size/S Denotes a PR that changes [10,99] lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: POW(x, y) math function not supported

4 participants