Skip to content

fix: preserve credentials for sharded repodata URLs #4347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jdr45 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

fix: preserve credentials for sharded repodata URLs #4347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions libmamba/src/api/channel_loader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,9 @@ namespace mamba

LOG_DEBUG << "Shard index fetched for " << subdir.name();
const auto& channel = subdir.channel();
std::string current_repodata_url = subdir.repodata_url().str();
std::string current_repodata_url = subdir.repodata_url().str(
specs::CondaURL::Credentials::Show
);
if (python_minor_version_for_prefilter.has_value())
{
LOG_DEBUG << "Shard prefilter on python minor version enabled with "
Expand Down Expand Up @@ -472,7 +474,9 @@ namespace mamba
continue;
}
auto si = std::move(sidx_result.value().value());
std::string sdir_url = subdirs[j].repodata_url().str();
std::string sdir_url = subdirs[j].repodata_url().str(
specs::CondaURL::Credentials::Show
);
all_shards.emplace_back(
std::move(si),
sdir_url,
Expand Down
Loading