config sub-command output hides secrets#4223
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4223 +/- ##
==========================================
- Coverage 53.65% 53.65% -0.01%
==========================================
Files 239 239
Lines 29349 29352 +3
Branches 3122 3123 +1
==========================================
+ Hits 15747 15748 +1
- Misses 13599 13601 +2
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| { | ||
| // Note: this function is intended to get more complex with incoming changes and need to be | ||
| // isolated in preparation for these changes. | ||
| const std::string dump_text = hide_secrets(config.dump(dump_opts, std::move(dump_names))); |
There was a problem hiding this comment.
Why not calling hide_secrets inside the Congifuration::dump method instead? This would allow to continue using operator<< instead of requiring a new free function.
There was a problem hiding this comment.
We could do that, although I was anticipating the need for a new function because of that pr that needs the fix from this pr.
But I can add it only in that pr if you prefer.
There was a problem hiding this comment.
Ah ok, then no need to change anything, let's merge!
2 participants
Description
Output from the
(micro) config ...subcommands are now filtered to hide secrets.Partial fix for #4222
Needed to complete #4202
Type of Change
Checklist
pre-commit run --alllocally in the source folder and confirmed that there are no linter errors.