Skip to content

Add Findzstd.cmake; change Windows find_packages usage to use it too#4159

Open
daym wants to merge 1 commit into
mamba-org:mainfrom
daym:findzstd
Open

Add Findzstd.cmake; change Windows find_packages usage to use it too#4159
daym wants to merge 1 commit into
mamba-org:mainfrom
daym:findzstd

Conversation

@daym

@daym daym commented Feb 8, 2026

Copy link
Copy Markdown
  • Add Findzstd.cmake

Description

This makes mamba find zstd when that zstd was built using their Makefile rather than their cmake (and hence their zstdConfig.cmake is not installed).

A logical cmake target zstd::libzstd_shared is created, referring to either a shared or a static library zstd (not specified which of static or shared to make it more general).

No zstdConfig.cmake in libzstd-dev in the following distributions:

  • Ubuntu 20.04 LTS (libzstd-dev)
  • Ubuntu 22.04 LTS (libzstd-dev)
  • CentOS 8 / RHEL 8 (libzstd-devel)
  • Debian 11 (Bullseye)
  • Fedora 43
  • Guix

A zstdConfig.cmake is in libzstd-dev in the following distributions:

  • Arch Linux
  • Debian 12 (Bookworm)

Type of Change

  • Bugfix
  • Feature / enhancement
  • CI / Documentation
  • Maintenance

Checklist

  • My code follows the general style and conventions of the codebase, ensuring consistency
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run pre-commit run --all locally in the source folder and confirmed that there are no linter errors.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@github-actions github-actions Bot added the release::bug_fixes For PRs fixing bugs label Feb 8, 2026
@codecov

codecov Bot commented Feb 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.83%. Comparing base (59f22ac) to head (f59e665).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4159   +/-   ##
=======================================
  Coverage   50.83%   50.83%           
=======================================
  Files         237      237           
  Lines       28228    28228           
  Branches     2919     2919           
=======================================
  Hits        14351    14351           
  Misses      13874    13874           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release::bug_fixes For PRs fixing bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant