Add Findzstd.cmake; change Windows find_packages usage to use it too#4159
Open
daym wants to merge 1 commit into
Open
Add Findzstd.cmake; change Windows find_packages usage to use it too#4159daym wants to merge 1 commit into
daym wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4159 +/- ##
=======================================
Coverage 50.83% 50.83%
=======================================
Files 237 237
Lines 28228 28228
Branches 2919 2919
=======================================
Hits 14351 14351
Misses 13874 13874
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* Add Findzstd.cmake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes mamba find zstd when that zstd was built using their
Makefilerather than theircmake(and hence theirzstdConfig.cmakeis not installed).A logical cmake target
zstd::libzstd_sharedis created, referring to either a shared or a static libraryzstd(not specified which of static or shared to make it more general).No
zstdConfig.cmakeinlibzstd-devin the following distributions:libzstd-dev)libzstd-dev)libzstd-devel)A
zstdConfig.cmakeis inlibzstd-devin the following distributions:Type of Change
Checklist
pre-commit run --alllocally in the source folder and confirmed that there are no linter errors.