fix: Clone pip packages with environment#4153
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4153 +/- ##
==========================================
- Coverage 51.13% 51.10% -0.04%
==========================================
Files 236 236
Lines 27645 27664 +19
Branches 2832 2833 +1
==========================================
Hits 14137 14137
- Misses 13505 13524 +19
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
712a0e9 to
fa5a935
Compare
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
5cae6b0 to
635aca1
Compare
|
Actually, it would be worth refactoring a few elements to reuse the code for exporting a YAML file specification from an environment and creating one from such a specification. |
| // Install packages from config | ||
| const auto& install_specs_vec = config.at("specs").value<std::vector<std::string>>(); |
There was a problem hiding this comment.
This is inspired from one of the install path, but we must not install those specifications modifying the configuration…
|
#4158 should come first. |
|
Cloning the pip packages would be realy cool. If you create a micromamba environment for very old Python versions: |
Description
Follow up of #4102 (comment).
Type of Change
Checklist
pre-commit run --alllocally in the source folder and confirmed that there are no linter errors.