Skip to content

Reduce code duplication by removing useless overrides #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vil02 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Reduce code duplication by removing useless overrides #755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/LinAlg/hiopMatrixDenseRaja.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,15 +251,12 @@ class hiopMatrixDenseRaja : public hiopMatrixDense
#endif
virtual size_type get_local_size_n() const { return n_local_; }
virtual size_type get_local_size_m() const { return m_local_; }
virtual MPI_Comm get_mpi_comm() const { return comm_; }

inline double* local_data_host() const { return data_host_; }
double* local_data() { return data_dev_; }
double* local_data_const() const { return data_dev_; }

public:
virtual size_type m() const { return m_local_; }
virtual size_type n() const { return n_global_; }
#ifdef HIOP_DEEPCHECKS
virtual bool assertSymmetry(double tol = 1e-16) const;
#endif
Expand Down
3 changes: 0 additions & 3 deletions src/LinAlg/hiopMatrixDenseRowMajor.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,6 @@ class hiopMatrixDenseRowMajor : public hiopMatrixDense
#endif
virtual size_type get_local_size_n() const { return n_local_; }
virtual size_type get_local_size_m() const { return m_local_; }
virtual MPI_Comm get_mpi_comm() const { return comm_; }

double* local_data_const() const { return M_[0]; }
double* local_data() { return M_[0]; }
Expand All @@ -233,8 +232,6 @@ class hiopMatrixDenseRowMajor : public hiopMatrixDense
inline double** get_M() { return M_; }

public:
virtual size_type m() const { return m_local_; }
virtual size_type n() const { return n_global_; }
#ifdef HIOP_DEEPCHECKS
virtual bool assertSymmetry(double tol = 1e-16) const;
#endif
Expand Down
2 changes: 0 additions & 2 deletions src/LinAlg/hiopMatrixRajaSparseTriplet.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,6 @@ class hiopMatrixRajaSymSparseTriplet : public hiopMatrixRajaSparseTriplet<MEMBAC
virtual bool assertSymmetry(double tol = 1e-16) const { return true; }
#endif

virtual void extract_diagonal(hiopVector& diag_out) const { assert(false && "not yet implemented"); }

virtual size_type numberOfOffDiagNonzeros() const;

virtual void set_Jac_FR(const hiopMatrixSparse& Jac_c,
Expand Down
2 changes: 0 additions & 2 deletions src/LinAlg/hiopVectorIntCompoundPD.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,6 @@ void hiopVectorIntCompoundPD::addVector(hiopVectorInt* v)

hiopVectorInt& hiopVectorIntCompoundPD::getVector(index_type index) const { return *(vectors_[index]); }

size_type hiopVectorIntCompoundPD::get_local_size() const { return sz_; }

size_type hiopVectorIntCompoundPD::get_num_parts() const { return n_parts_; }

} // namespace hiop
2 changes: 0 additions & 2 deletions src/LinAlg/hiopVectorIntCompoundPD.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,6 @@ class hiopVectorIntCompoundPD : public hiopVectorInt

hiopVectorInt& getVector(index_type index) const;

size_type get_local_size() const;

/* @brief return the number of parts in this compound vector */
size_type get_num_parts() const;

Expand Down
Loading