Skip to content

Fix legacy CMake targets - #1105

Open
adayton1 wants to merge 4 commits into
developfrom
bugfix/cmake_target
Open

Fix legacy CMake targets#1105
adayton1 wants to merge 4 commits into
developfrom
bugfix/cmake_target

Conversation

@adayton1

@adayton1 adayton1 commented Aug 5, 2026

Copy link
Copy Markdown
Member

Apparently there are issues when trying to export targets twice even if they end up with different names. So now we try creating an INTERFACE library called umpire and link it to umpire::umpire. Note that the "umpire" target gains properties only transitively, not on the target itself.

Also fixes creation of umpire_device target.

CMake Error: install(EXPORT "chai-targets" ...) includes target "chai" which requires target "umpire" that is not in this export set, but in multiple other export sets: lib/cmake/umpire/umpire-targets.cmake, lib/cmake/umpire/umpire-non-namespaced-targets.cmake.
 
An exported target cannot depend upon another target which is exported multiple times. Consider consolidating the exports of the "umpire" target to a single export.

See #1102, #1101, #1100, #1083, #1067

rhornung67
rhornung67 previously approved these changes Aug 5, 2026
@kab163

kab163 commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

@adayton1 - Did this work for your use case? I want to double check before we merge these changes.

@adayton1

adayton1 commented Aug 6, 2026

Copy link
Copy Markdown
Member Author

It's still failing in some cases - just trying to work through them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants