Fix legacy CMake targets - #1105
Open
adayton1 wants to merge 4 commits into
Open
Conversation
rhornung67
previously approved these changes
Aug 5, 2026
kab163
approved these changes
Aug 5, 2026
Collaborator
|
@adayton1 - Did this work for your use case? I want to double check before we merge these changes. |
Member
Author
|
It's still failing in some cases - just trying to work through them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently there are issues when trying to export targets twice even if they end up with different names. So now we try creating an INTERFACE library called umpire and link it to umpire::umpire. Note that the "umpire" target gains properties only transitively, not on the target itself.
Also fixes creation of umpire_device target.
See #1102, #1101, #1100, #1083, #1067