Add live stream memory cleanup hook#903
Open
fastagents wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds cleanup for live stream resources while preserving warmed model state.
cleanup_stream()hook for live pipelinesmalloc_trim()by default after stream cleanupWhy
The current live pipeline reset clears parent-side multiprocessing queues, but warm live pipelines can still retain stream-scoped objects inside the child pipeline and output publishing path.
For tensor-backed output frames, retained references can also keep shared-memory file descriptors open. Under long streams or publish backpressure, that can lead to unnecessary memory and FD retention even though the model itself should remain warm.
This patch keeps the official live-runner behavior intact while making cleanup explicit and bounded.
Notes
Testing
python3 -m pytest -q runner/tests/live/test_stream_cleanup_source.pycompileallon the edited source/test files