-
Notifications
You must be signed in to change notification settings - Fork 191
Data streams v2 #1192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Data streams v2 #1192
Changes from 4 commits
b861454
87b96c7
ca896ff
833b6ee
46a0ac0
c92a56f
7dcdde1
5952b79
3ec690a
0d93e09
7162dbc
10c34c7
ae7c6d1
d537a7f
4c5138f
8e7509f
f9449ca
3768723
db5c6aa
e8d64d2
c70a15e
c8d4a44
03c81b3
ea5514f
7495a24
8b7ec4d
54b160c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| --- | ||
| livekit: patch | ||
| livekit-api: patch | ||
| livekit-datatrack: patch | ||
| livekit-ffi: patch | ||
| livekit-protocol: patch | ||
| livekit-uniffi: patch | ||
| --- | ||
|
|
||
| Add data streams v2 - #1192 (@1egoman) |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,6 +52,7 @@ semver = "1.0" | |
| libloading = { version = "0.8.6" } | ||
| bytes = "1.10.1" | ||
| bmrng = "0.5.2" | ||
| flate2 = "1" | ||
| base64 = "0.22" | ||
|
Comment on lines
53
to
56
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note that
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure if this is is worth doing yet, but it might be worth adding a "compression" feature to this crate to conditionally include this dep. It would be enabled by default, but would provide users who do not want compression to disable it at the feature level.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I lean towards not doing it and adding it later if people wanted to opt out. But, I could be convinced otherwise if there's a really good use case. Also, in case it's relevant,
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My concern would be more how it affects compile time and binary size; probably insignificant but it might be worth checking with |
||
|
|
||
| [dev-dependencies] | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.