fix: preserve transcription item id#6120
Conversation
|
it seems to have merge conflicts |
|
Thanks for flagging it — I'm working through a rebase now. The branch drift turned out to be larger than expected, so I want to untangle it cleanly before I push an update. |
|
Updated the branch to resolve the merge conflicts by merging the latest Validation run:
The PR now reports as mergeable on GitHub. I also noticed the CLA check is still pending/not signed, which appears to be the remaining non-code item. |
|
Hi, can u pls request re-review this has not been merged yet, or could it be you have not signed CLA yet . |
|
I checked the branch again. The code change itself is already rebased and the targeted test passed in the last update; the remaining blocker appears to be the CLA status rather than an outstanding code review issue. Once the CLA is recognized on GitHub, I'm happy to request re-review immediately. |
|
@nightcityblade could you please sign the CLA? |
173768a to
e697970
Compare
|
I’m checking the CLA flow from this account now. The branch itself is already up to date and the targeted regression test passed in the last code update; once GitHub recognizes the CLA, I’ll request re-review immediately. |
| type: Literal["user_input_transcribed"] = "user_input_transcribed" | ||
| transcript: str | ||
| is_final: bool | ||
| item_id: str | None = None |
There was a problem hiding this comment.
Pretty sure we will need to expose even more fields in the future, extra seems more appropriate
| item_id: str | None = None | |
| extra: dict = {} |
We can then do something like extra["openai"]["item_id"] ?
Fixes #6109
Summary
item_idonUserInputTranscribedEventTesting
uv run pytest tests/test_agent_session.py -quv run pytest tests/test_agent_session.py::test_realtime_user_input_transcription_preserves_item_id -quv run ruff check livekit-agents/livekit/agents/voice/events.py livekit-agents/livekit/agents/voice/agent_activity.py tests/test_agent_session.py