Skip to content

fix(google): broaden Gemini 3 Flash detection#1880

Merged
chenghao-mou merged 5 commits into
mainfrom
retyping-grannies-tenderly
Jun 26, 2026
Merged

fix(google): broaden Gemini 3 Flash detection#1880
chenghao-mou merged 5 commits into
mainfrom
retyping-grannies-tenderly

Conversation

@rosetta-livekit-bot

@rosetta-livekit-bot rosetta-livekit-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Testing

  • pnpm exec prettier --check plugins/google/src/llm.ts
  • pnpm exec eslint plugins/google/src/llm.ts
  • pnpm exec tsc -p plugins/google/tsconfig.json --noEmit (blocked by existing workspace resolution/type errors unrelated to this change, including missing @livekit/agents workspace declarations)

Ported from livekit/agents#6210

Original PR description

Summary

  • _is_gemini_3_flash_model previously checked for the substring "gemini-3-flash", which missed gemini-3.5-flash (dot notation)
  • New logic: m.startswith("gemini-3") and "flash" in m — covers both gemini-3-flash-preview and gemini-3.5-flash, while correctly excluding gemini-3-pro-preview
  • Also removes the redundant startswith branch that was a subset of the in check

Test plan

  • Confirm gemini-3.5-flash returns True
  • Confirm gemini-3-flash-preview returns True
  • Confirm gemini-3-pro-preview returns False
  • Confirm gemini-2.5-flash returns False

🤖 Generated with Claude Code

@changeset-bot

changeset-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6fb3f9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@livekit/agents-plugin-google Patch
@livekit/agents Patch
@livekit/agents-plugin-anam Patch
@livekit/agents-plugin-assemblyai Patch
@livekit/agents-plugin-baseten Patch
@livekit/agents-plugin-bey Patch
@livekit/agents-plugin-cartesia Patch
@livekit/agents-plugin-cerebras Patch
@livekit/agents-plugin-deepgram Patch
@livekit/agents-plugin-did Patch
@livekit/agents-plugin-elevenlabs Patch
@livekit/agents-plugin-fishaudio Patch
@livekit/agents-plugin-hedra Patch
@livekit/agents-plugin-hume Patch
@livekit/agents-plugin-inworld Patch
@livekit/agents-plugin-lemonslice Patch
@livekit/agents-plugin-liveavatar Patch
@livekit/agents-plugin-livekit Patch
@livekit/agents-plugin-minimax Patch
@livekit/agents-plugin-mistral Patch
@livekit/agents-plugin-mistralai Patch
@livekit/agents-plugin-neuphonic Patch
@livekit/agents-plugin-openai Patch
@livekit/agents-plugin-perplexity Patch
@livekit/agents-plugin-phonic Patch
@livekit/agents-plugin-resemble Patch
@livekit/agents-plugin-rime Patch
@livekit/agents-plugin-runway Patch
@livekit/agents-plugin-sarvam Patch
@livekit/agents-plugin-silero Patch
@livekit/agents-plugin-soniox Patch
@livekit/agents-plugin-tavus Patch
@livekit/agents-plugins-test Patch
@livekit/agents-plugin-trugen Patch
@livekit/agents-plugin-xai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@chenghao-mou chenghao-mou merged commit 8267bf3 into main Jun 26, 2026
9 checks passed
@chenghao-mou chenghao-mou deleted the retyping-grannies-tenderly branch June 26, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant