hostcheck: fix sizing and height calculation for status label - #1883
Open
Heckie75 wants to merge 1 commit into
Open
hostcheck: fix sizing and height calculation for status label#1883Heckie75 wants to merge 1 commit into
Heckie75 wants to merge 1 commit into
Conversation
Member
|
cc @schorschii |
Contributor
Author
|
@schorschii Actually the change fixes the broken design in case that scaling is configured. In my case I have a 4K screen and set the scaling to 125%. Without this fix it looks like this: The red/green panel is too big. Also the font is far to big. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fix hostcheck@schorschii desklet sizing by removing incorrect global.ui_scale scaling from label dimension calculations, using the label’s preferred rendered height, and making the canvas height match the actual label height; also add box-sizing: border-box to the status box stylesheet so the layout behaves consistently.