feat: add decoration state management#1085
Draft
deepin-wm wants to merge 1 commit into
Draft
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @deepin-wm, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-wm The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
deepin-wm
force-pushed
the
fix/WM-70-layer-shell-shadow-v2
branch
4 times, most recently
from
0203c07 to
ff7c20e
Compare
1. Add DecorationState enum (NotSet/EnabledDefault/Custom) 2. Implement set_shadow_enabled/set_border_enabled requests 3. Create Layer Shell decoration on-demand when enabled 4. Add ShadowParams/BorderParams structs with Q_GADGET 5. Add shadowParams/borderParams properties for QML 6. Add shadowEnabled()/borderEnabled() methods 7. Set EnabledDefault for XDG Toplevel, NotSet for Layer Shell 8. Update InterfaceVersion to 2 Log: Layer Shell windows can now enable decoration on demand; OSD no longer shows unexpected shadow Influence: 1. Test OSD display no longer shows unexpected shadow 2. Test Layer Shell with enabled shadow/border display correctly 3. Test XDG toplevel decoration behavior is unchanged 4. Test dynamic enable/disable works at runtime feat: 添加 Layer Shell 装饰状态管理 1. 新增 DecorationState 枚举 (NotSet/EnabledDefault/Custom) 2. 实现 set_shadow_enabled/set_border_enabled 请求处理 3. Layer Shell 窗口按需创建装饰 4. 添加 ShadowParams/BorderParams 结构体 5. 添加 shadowParams/borderParams 属性用于 QML 传递 6. 添加 shadowEnabled()/borderEnabled() 方法 7. XDG Toplevel 默认 EnabledDefault，Layer Shell 默认 NotSet 8. 更新 InterfaceVersion 为 2 Log: Layer Shell窗口可按需启用装饰；OSD不再显示意外阴影 Influence: 1. 测试OSD显示无意外阴影 2. 测试启用阴影/边框的Layer Shell表面正确显示 3. 测试XDG toplevel装饰行为未改变 4. 测试运行时动态启用/禁用正常工作 PMS: BUG-367541
deepin-wm
force-pushed
the
fix/WM-70-layer-shell-shadow-v2
branch
from
b424ccb to
9ea7395
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Layer Shell decoration on-demand creation with simplified DecorationState enum.
添加装饰状态管理
Log: Layer Shell 窗口装饰按需创建
Influence: 无影响
PMS: BUG-367541
Related: WM-70