tests: add source root to include paths#755
Merged
Merged
Conversation
The test target compiles widget sources directly from the shared source list. Some of those sources include private util headers through paths such as "util/dprivateaccessor_p.h", but the target only adds src/widgets and the public include directories to its include search path. Add the source root to the test target's private include paths so source-internal includes resolve the same way they do for the library target. This fixes builds with tests enabled after the private accessor refactor.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @felixonmars, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
BLumia
approved these changes
Jul 10, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, felixonmars The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test target compiles widget sources directly from the shared source list. Some of those sources include private util headers through paths such as "util/dprivateaccessor_p.h", but the target only adds src/widgets and the public include directories to its include search path.
Add the source root to the test target's private include paths so source-internal includes resolve the same way they do for the library target.
This fixes builds with tests enabled after the private accessor refactor.