Skip to content

Add support for credential_injector #6785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrhee17 merged 5 commits into from
Jun 4, 2026

address comments by @minwoox

1b2f161
Select commit
Loading
Failed to load commit list.
Merged

Add support for credential_injector #6785

address comments by @minwoox
1b2f161
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 4, 2026 in 1s

75.00% (+0.54%) compared to 8150425

View this Pull Request on Codecov

75.00% (+0.54%) compared to 8150425

Details

Codecov Report

❌ Patch coverage is 68.24645% with 67 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.00%. Comparing base (8150425) to head (1b2f161).
⚠️ Report is 478 commits behind head on main.

Files with missing lines Patch % Lines
...ia/xds/filter/CredentialInjectorFilterFactory.java 60.86% 14 Missing and 4 partials ⚠️
...main/java/com/linecorp/armeria/xds/FilterUtil.java 57.57% 10 Missing and 4 partials ⚠️
...om/linecorp/armeria/xds/GenericSecretSnapshot.java 27.77% 13 Missing ⚠️
.../com/linecorp/armeria/xds/GenericSecretStream.java 71.42% 4 Missing and 2 partials ⚠️
...ain/java/com/linecorp/armeria/xds/RouteStream.java 81.48% 3 Missing and 2 partials ⚠️
...m/linecorp/armeria/xds/ListenerResourceParser.java 71.42% 2 Missing and 2 partials ⚠️
...linecorp/armeria/xds/filter/HttpFilterFactory.java 50.00% 1 Missing and 1 partial ⚠️
...linecorp/armeria/xds/filter/NoopXdsHttpFilter.java 0.00% 2 Missing ⚠️
...orp/armeria/xds/stream/RescheduleSubscription.java 88.23% 0 Missing and 2 partials ⚠️
...com/linecorp/armeria/xds/filter/XdsHttpFilter.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #6785      +/-   ##
============================================
+ Coverage     74.46%   75.00%   +0.54%     
- Complexity    22234    24915    +2681     
============================================
  Files          1963     2215     +252     
  Lines         82437    92677   +10240     
  Branches      10764    12105    +1341     
============================================
+ Hits          61385    69512    +8127     
- Misses        15918    17372    +1454     
- Partials       5134     5793     +659

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov