Skip to content

Broadcast holder commitment for currently confirmed funding#3939

Merged
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom
wpaulino:splice-funding-commitment-broadcast
Aug 6, 2025
Merged

Broadcast holder commitment for currently confirmed funding#3939
TheBlueMatt merged 2 commits into
lightningdevkit:mainfrom
wpaulino:splice-funding-commitment-broadcast

Broadcast holder commitment for currently confirmed funding

89ce01d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 5, 2025 in 0s

88.76% (-0.18%) compared to ecce268

View this Pull Request on Codecov

88.76% (-0.18%) compared to ecce268

Details

Codecov Report

❌ Patch coverage is 47.00000% with 106 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.76%. Comparing base (ecce268) to head (89ce01d).
⚠️ Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/chain/channelmonitor.rs 43.24% 92 Missing and 13 partials ⚠️
lightning/src/chain/onchaintx.rs 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3939      +/-   ##
==========================================
- Coverage   88.93%   88.76%   -0.18%     
==========================================
  Files         174      173       -1     
  Lines      123842   124326     +484     
  Branches   123842   124326     +484     
==========================================
+ Hits       110142   110357     +215     
- Misses      11254    11553     +299     
+ Partials     2446     2416      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.