fix: preserve leading blank lines in MarkdownRenderer - #481
Open
BetterAndBetterII wants to merge 1 commit into
Open
fix: preserve leading blank lines in MarkdownRenderer#481BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
Blank-line tokens at the start of the document were rendered as empty strings, so parse-then-markdown of a source that began with newlines dropped them. Record the leading newline count on the first blank_line token and emit it when reformatting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #366.
MarkdownRendererdropped start-of-document blank lines, so a parse-then-markdown round trip of"\n\n\n\nabc"became'abc\n'.The parser now records the leading newline count on the first
blank_linetoken (cursor == 0). The renderer emits those newlines when reformatting. Mid-document blanks are unchanged. The renderer still ends with a newline viastrip_end, matching the rest ofMarkdownRenderer.Test:
tests/test_renderers.py::TestMarkdownRendererRoundTrip::test_leading_blank_lines_preserved.