fix: route image directive src through safe_url - #442
Merged
Conversation
The inline image renderer (HTMLRenderer.image) routes src through safe_url, but the image/figure directive's render_block_image renders src with escape_text only. As a result `.. image:: javascript:alert` produced `<img src="javascript:alert">`, inconsistent with the inline `` path which yields `src="#harmful-link"`. This is not a known exploit (javascript: in <img src> does not execute in current browsers), but the directive should match the renderer's link/image safety contract so the two paths cannot drift. - render_block_image now calls self.safe_url(src); this is a drop-in for the previous escape_text(src) on any non-harmful scheme (safe_url returns escape_text(url) in that case) and maps harmful schemes to #harmful-link. - Add behaviour-pinning tests for harmful/encoded/safe scheme variants across inline links, reference links, and the image directive. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
lepture
approved these changes
May 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
=======================================
Coverage 91.70% 91.70%
=======================================
Files 34 34
Lines 2639 2639
Branches 430 430
=======================================
Hits 2420 2420
Misses 147 147
Partials 72 72
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The inline image renderer (HTMLRenderer.image) routes src through safe_url, but the image/figure directive's render_block_image renders src with escape_text only. As a result
.. image:: javascript:alertproduced<img src="javascript:alert">, inconsistent with the inlinepath which yieldssrc="#harmful-link".This is not a known exploit (javascript: in
does not execute in current browsers), but the directive should match the renderer's link/image safety contract so the two paths cannot drift.