🐛 Fix error on large uploads and lacking progress print for gcsfs - #3832
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3832 +/- ##
==========================================
- Coverage 91.52% 86.99% -4.53%
==========================================
Files 88 88
Lines 15723 15734 +11
==========================================
- Hits 14390 13688 -702
- Misses 1333 2046 +713
🚀 New features to boost your workflow:
|
|
Deployment URL: https://7ffffe65.lamindb.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related laminlabs/lamindb-setup#1375
Fixes an indefinite hang in cloud transfers on jupyter notebooks, where an upload or download would freeze while asyncio logged
AssertionError: Data should not be emptyfrom_SelectorSocketTransport._write_sendaround 100k times per second.Both symptoms are one event: when the backend closes a connection mid-request, asyncio can be left with a socket writer registered for an empty write buffer, and
_write_sendasserts before it reaches the code that would unregister it, so the loop re-runs the failing callback forever and starves every other transfer sharing the fsspec IO loop.The new
lamindb_setup/core/_asyncio_write_spin.pyinstalls an exception handler that unregisters the stuck writer and aborts the transport, so the interrupted request fails like a normal dropped connection and the backend retries it. It only touches selector loops and this one assertion, so everything else is unaffected.Reported without a diagnosis in fsspec/gcsfs#604 and fsspec/s3fs#909; a surviving variant of python/cpython#115514 that still reproduces on 3.13.12.