Skip to content

♻️ Separate the HasSynonyms and HasAbbr MixIns from the CanCurate MixIn - #3823

Merged
falexwolf merged 4 commits into
mainfrom
refactorcancurate
Jul 24, 2026
Merged

♻️ Separate the HasSynonyms and HasAbbr MixIns from the CanCurate MixIn#3823
falexwolf merged 4 commits into
mainfrom
refactorcancurate

Conversation

@falexwolf

@falexwolf falexwolf commented Jul 23, 2026

Copy link
Copy Markdown
Member

Without the separation one might create registries that don't have the necessary fields synonyms/abbr fields but offer methods to manipulate them.

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.96%. Comparing base (43a1701) to head (7ed992b).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3823      +/-   ##
==========================================
- Coverage   91.52%   86.96%   -4.56%     
==========================================
  Files          88       88              
  Lines       15723    15747      +24     
==========================================
- Hits        14390    13694     -696     
- Misses       1333     2053     +720     
Files with missing lines Coverage Δ
lamindb/models/__init__.py 100.00% <100.00%> (ø)
lamindb/models/can_curate.py 97.46% <100.00%> (+0.78%) ⬆️
lamindb/models/feature.py 93.35% <100.00%> (ø)
lamindb/models/project.py 99.63% <100.00%> (ø)
lamindb/models/sqlrecord.py 92.08% <ø> (+0.07%) ⬆️

... and 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

Deployment URL: https://7dd2ab44.lamindb.pages.dev

@falexwolf falexwolf changed the title ♻️ Refactor CanCurate ♻️ Separate the HasSynonyms and HasAbbr MixIns from the the CanCurate MixIn Jul 24, 2026
@falexwolf
falexwolf merged commit 01edf83 into main Jul 24, 2026
20 checks passed
@falexwolf
falexwolf deleted the refactorcancurate branch July 24, 2026 06:23
@falexwolf falexwolf changed the title ♻️ Separate the HasSynonyms and HasAbbr MixIns from the the CanCurate MixIn ♻️ Separate the HasSynonyms and HasAbbr MixIns from the CanCurate MixIn Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant