✨ Allow users to delete non-empty storages - #3690
Open
Koncopd wants to merge 5 commits into
Open
Conversation
Member
|
Can you add more context? Reading the PR title and skimming the changes this looks like we might introduce danger for accidental data loss? |
Member
Author
|
@falexwolf the context is here https://laminlabs.slack.com/archives/C062QDNMN6M/p1778148568628459 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3690 +/- ##
==========================================
- Coverage 91.55% 86.13% -5.43%
==========================================
Files 88 88
Lines 14855 14864 +9
==========================================
- Hits 13601 12803 -798
- Misses 1254 2061 +807
🚀 New features to boost your workflow:
|
|
Deployment URL: https://33377d4c.lamindb.pages.dev |
Koncopd
force-pushed
the
disconnect_storage
branch
from
May 25, 2026 12:55
952dd34 to
cd4c6fb
Compare
Member
|
I see, makes sense. Let me check the implementation. |
Koncopd
force-pushed
the
disconnect_storage
branch
from
May 27, 2026 08:51
cd4c6fb to
00aa1e1
Compare
falexwolf
force-pushed
the
main
branch
2 times, most recently
from
July 18, 2026 08:03
0fc6700 to
4001ef8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.