Skip to content

✨ Allow users to delete non-empty storages - #3690

Open
Koncopd wants to merge 5 commits into
mainfrom
disconnect_storage
Open

✨ Allow users to delete non-empty storages#3690
Koncopd wants to merge 5 commits into
mainfrom
disconnect_storage

Conversation

@Koncopd

@Koncopd Koncopd commented May 20, 2026

Copy link
Copy Markdown
Member

No description provided.

@falexwolf

Copy link
Copy Markdown
Member

Can you add more context? Reading the PR title and skimming the changes this looks like we might introduce danger for accidental data loss?

@Koncopd

Koncopd commented May 20, 2026

Copy link
Copy Markdown
Member Author

@codecov

codecov Bot commented May 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.31034% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.13%. Comparing base (13a7640) to head (00aa1e1).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lamindb/models/storage.py 79.31% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3690      +/-   ##
==========================================
- Coverage   91.55%   86.13%   -5.43%     
==========================================
  Files          88       88              
  Lines       14855    14864       +9     
==========================================
- Hits        13601    12803     -798     
- Misses       1254     2061     +807     
Files with missing lines Coverage Δ
lamindb/models/storage.py 91.66% <79.31%> (-3.83%) ⬇️

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented May 20, 2026

Copy link
Copy Markdown

Deployment URL: https://33377d4c.lamindb.pages.dev

@falexwolf

Copy link
Copy Markdown
Member

I see, makes sense. Let me check the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants