remove null transport#98
Merged
Merged
Conversation
Closed
Closed
Member
Well, we can bump the minimum version to 7 anytime. The problem is that this class is completely unusable when we do. As such, I'm going to wrap it in the 2.12.0 changes. |
weierophinney
requested changes
Jul 30, 2020
weierophinney
left a comment
weierophinney
left a comment
Member
There was a problem hiding this comment.
We need to keep the 'null' => InMemory::class mappings to retain BC. I'll make that change and push back to your branch.
| { | ||
| return [ | ||
| ['file', File::class], | ||
| ['null', InMemory::class], |
Member
There was a problem hiding this comment.
We can actually keep these references to keep BC for end-users.
| 'file' => File::class, | ||
| 'inmemory' => InMemory::class, | ||
| 'memory' => InMemory::class, | ||
| 'null' => InMemory::class, |
Member
There was a problem hiding this comment.
We can keep this, as it's a string; removing it would be a BC break.
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
Prevents BC breaks. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
weierophinney
force-pushed
the
remove-null-transport
branch
from
e7de3b1 to
9b19a48
Compare
artemii-karkusha
pushed a commit
to artemii-karkusha/laminas-mail
that referenced
this pull request
May 24, 2023
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Re-create zendframework/zend-mail#195 . Null is reserved keyword in php 7+. It is for next major version when minimum php version upped to php 7+. Fixes #36