feat(desktop): add core-js polyfill#7043
Open
Nixieboluo wants to merge 1 commit into
Open
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a CoreJS polyfill to the desktop app entrypoint so the client bundle has stable JavaScript runtime APIs available in older Chromium-based browsers.
Changes included:
core-js@3.33.3as a directdesktopdependencycore-js/stableat the top ofdesktop/src/pages/_app.tsxdesktopCompatibility
This targets Chrome 86 and newer.
The polyfill is loaded before the desktop app initializes, so stable ECMAScript APIs provided by CoreJS are available across the desktop client runtime. This is intended to support
environments based on Chromium 86, including Chrome 86 and compatible embedded Chromium/WebView runtimes.