Add riscv64 (linux) to CSI_PROW_BUILD_PLATFORMS#300
Open
andyzhangx wants to merge 1 commit into
Open
Conversation
Now that riscv64 support is available for the distroless Docker base image (GoogleContainerTools/distroless#2001), add linux/riscv64 to the default build platforms so all CSI sidecar repos pick it up automatically. Related: kubernetes-csi/livenessprobe#403 Related: kubernetes-csi/external-provisioner#1481
k8s-ci-robot
added
release-note
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XS
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
k8s-ci-robot
added
the
cncf-cla: yes
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Member
|
/hold related to: kubernetes/release#4312 |
k8s-ci-robot
added
the
do-not-merge/hold
Member
|
/lgtm cancel |
k8s-ci-robot
removed
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add
linux riscv64to the defaultCSI_PROW_BUILD_PLATFORMSinprow.shso that all CSI sidecar repos that consume csi-release-tools automatically build and publish riscv64 images.Now that riscv64 support is available for the distroless Docker base image (GoogleContainerTools/distroless#2001), riscv64 can be added as a supported architecture across the CSI ecosystem.
This was requested in:
Which issue(s) this PR fixes:
Related to kubernetes-csi/livenessprobe#403
Related to kubernetes-csi/external-provisioner#1481
Special notes for your reviewer:
This is a one-line change to
prow.shline 81, addinglinux riscv64 riscv64 -riscv64to the platform list (following the same pattern as other architectures).Does this PR introduce a user-facing change?