Skip to content

fix(ui): fix reset-all-defaults and slider rounding for performance filters#2822

Open
manaswinidas wants to merge 2 commits into
kubeflow:mainfrom
manaswinidas:fix-cold-start-bugs
Open

fix(ui): fix reset-all-defaults and slider rounding for performance filters#2822
manaswinidas wants to merge 2 commits into
kubeflow:mainfrom
manaswinidas:fix-cold-start-bugs

Conversation

@manaswinidas

@manaswinidas manaswinidas commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Description

  • Add missing COLD_START_LOAD_TIME and MAX_RPS to resetPerformanceFiltersToDefaults
  • Handle all number filter keys in getDefaultFiltersFromNamedQuery
  • Round slider range bounds and values to integers for GB-based filters
  • Update Cypress reset test to cover cold start filter
Screen.Recording.2026-06-12.at.8.52.45.PM.mov
Screenshot 2026-06-12 at 8 52 32 PM Screenshot 2026-06-12 at 9 11 26 PM

All applied and tested midstream

How Has This Been Tested?

  1. Test whether cold-start load time filters disappear on "Reset all defaults"
  2. Divider between the two filters on the sidebar
  3. Container size slider min and max values are rounded

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

…ilters

Signed-off-by: manaswinidas <dasmanaswini10@gmail.com>
@google-oss-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from manaswinidas. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: manaswinidas <dasmanaswini10@gmail.com>
@manaswinidas manaswinidas force-pushed the fix-cold-start-bugs branch from eb088b3 to 0960825 Compare June 12, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant