feat(catalog): add orderBy=RECOMMENDED to findModels, deprecate recommendations param - #2819
Merged
Merged
Conversation
pboyd
force-pushed
the
order-by-recommended
branch
from
June 16, 2026 16:26
a418b30 to
4a8d64b
Compare
pboyd
force-pushed
the
order-by-recommended
branch
from
June 16, 2026 16:28
4a8d64b to
442d189
Compare
…mendations param Passing recommendations=true to GET /api/model_catalog/v1alpha1/models was confusing because it prevented using orderBy. This change makes orderBy=RECOMMENDED equivalent: Pareto filtering is applied and models are sorted by recommended latency, with sortOrder honored (ASC = lowest latency first, DESC = highest latency first). The recommendations boolean parameter is retained for backward compatibility but marked deprecated in the OpenAPI spec. Note that sortOrder is now honored when recommendations=true as well; the default ASC behavior is unchanged. Assisted-by: Claude Opus 4.6 Signed-off-by: Paul Boyd <paul@pboyd.io>
pboyd
force-pushed
the
order-by-recommended
branch
from
June 16, 2026 16:30
442d189 to
33352a9
Compare
pboyd
marked this pull request as ready for review
June 16, 2026 16:30
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adysenrothman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
manaswinidas
added a commit
to manaswinidas/model-registry
that referenced
this pull request
Jul 10, 2026
…sort Make performanceParams.orderBy dynamic: default to RECOMMENDED (Pareto filtering from PR kubeflow#2819) and switch to cold_start_time_to_load_seconds only when the "Lowest Cold Start" sort option is selected. Assisted-by: Claude Signed-off-by: manaswinidas <dasmanaswini10@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
manaswinidas
added a commit
to manaswinidas/model-registry
that referenced
this pull request
Jul 14, 2026
…sort Make performanceParams.orderBy dynamic: default to RECOMMENDED (Pareto filtering from PR kubeflow#2819) and switch to cold_start_time_to_load_seconds only when the "Lowest Cold Start" sort option is selected. Assisted-by: Claude Signed-off-by: manaswinidas <dasmanaswini10@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
google-oss-prow Bot
pushed a commit
that referenced
this pull request
Jul 21, 2026
…RECOMMENDED (#2889) * feat(ui): migrate model catalog from recommendations=true to orderBy=RECOMMENDED Replace deprecated `recommendations: true` with `orderBy: 'RECOMMENDED'` in the models API call for performance view. The performance artifacts endpoint (used by PerformanceInsightsView and ModelCatalogCardBody) is unaffected. Assisted-by: Claude Signed-off-by: manaswinidas <dasmanaswini10@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: manaswinidas <dasmanaswini10@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> * feat(ui): use orderBy=cold_start_time_to_load_seconds for cold start sort Make performanceParams.orderBy dynamic: default to RECOMMENDED (Pareto filtering from PR #2819) and switch to cold_start_time_to_load_seconds only when the "Lowest Cold Start" sort option is selected. Assisted-by: Claude Signed-off-by: manaswinidas <dasmanaswini10@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> * feat(ui): remove recommendations=true from performance artifacts, fix card sort - Remove deprecated `recommendations: true` from all performance artifact API calls (ModelCatalogCardBody, PerformanceInsightsView, hook, service, type definition) - Fix card body to pull `sortBy` from ModelCatalogContext and sort artifacts by cold_start ASC when "Lowest Cold Start" sort is active, so the displayed metric matches the model's gallery position - Default card artifact fetch to `orderBy=RECOMMENDED` when no latency filter or cold start sort is active - Update COLD_START_TIME_TO_LOAD enum value to use full artifact path Assisted-by: Claude Signed-off-by: manaswinidas <dasmanaswini10@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> * fix(ui): prioritize cold start sort over latency in card artifacts When sorting by "Lowest Cold Start", the card's /performance_artifacts call now always orders by cold_start_time_to_load_seconds.double_value regardless of whether a latency filter is active. Previously the latency filter took priority, causing the displayed cold start metric to not match the model's gallery position. Also use stripArtifactsPrefix for the cold start orderBy value to match the short-form format expected by the performance_artifacts endpoint (cold_start_time_to_load_seconds.double_value, not artifacts.cold_start_time_to_load_seconds.double_value). Fix Cypress test that asserted recommendations=true (now removed). Signed-off-by: manaswinidas <dasmanaswini10@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> * refactor(ui): remove DRY violation and fix stale references - Remove duplicate SortField.COLD_START_TIME_TO_LOAD enum member; use ModelCatalogNumberFilterKey.COLD_START_LOAD_TIME directly (single source of truth for the field path) - Strengthen Cypress test: assert orderBy= is present, not just that recommendations= is absent - Update stale mock comment: recommendations=true → orderBy=RECOMMENDED Signed-off-by: manaswinidas <dasmanaswini10@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> --------- Signed-off-by: manaswinidas <dasmanaswini10@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Passing
recommendations=truetoGET /api/model_catalog/v1alpha1/modelswas confusing because it prevented usingorderBy. This change makesorderBy=RECOMMENDEDequivalent: Pareto filtering is applied and models are sorted by recommended latency, withsortOrderhonored (ASC= lowest latencyfirst,
DESC= highest latency first).The recommendations boolean parameter is retained for backward compatibility but marked deprecated in the OpenAPI spec.
How Has This Been Tested?
Compared the output of
recommendations=trueandorderBy=RECOMMENDEDand verified there was no difference.Merge criteria:
DCOcheck)