feat(catalog): add orderBy=RECOMMENDED to findModels, deprecate recommendations param#2819
Draft
pboyd wants to merge 1 commit into
Draft
feat(catalog): add orderBy=RECOMMENDED to findModels, deprecate recommendations param#2819pboyd wants to merge 1 commit into
pboyd wants to merge 1 commit into
Conversation
…mendations param Passing recommendations=true to GET /api/model_catalog/v1alpha1/models was confusing because it prevented using orderBy. This change makes orderBy=RECOMMENDED equivalent: Pareto filtering is applied and models are sorted by recommended latency, with sortOrder honored (ASC = lowest latency first, DESC = highest latency first). The recommendations boolean parameter is retained for backward compatibility but marked deprecated in the OpenAPI spec. Note that sortOrder is now honored when recommendations=true as well; the default ASC behavior is unchanged. Assisted-by: Claude Opus 4.6 Signed-off-by: Paul Boyd <paul@pboyd.io>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Passing
recommendations=truetoGET /api/model_catalog/v1alpha1/modelswas confusing because it prevented usingorderBy. This change makesorderBy=RECOMMENDEDequivalent: Pareto filtering is applied and models are sorted by recommended latency, withsortOrderhonored (ASC= lowest latencyfirst,
DESC= highest latency first).The recommendations boolean parameter is retained for backward compatibility but marked deprecated in the OpenAPI spec.
How Has This Been Tested?
Merge criteria:
DCOcheck)