Avoid showing tldr buffer in multiple windows - #44
Open
ErikPrantare wants to merge 1 commit into
Open
Conversation
with-temp-buffer-window changed the buffer of the current window, making the switch-to-buffer-other-window in effect show the buffer twice. The switch-to-buffer-other-window also meant that if the tldr buffer was in the selected window, it would still display it in another window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with-temp-buffer-windowchanged the buffer of the selected window,making the
switch-to-buffer-other-windowin effect show the buffertwice.
The
switch-to-buffer-other-windowalso meant that if the tldr bufferwas in the selected window, it would still display it in another
window.
This pull request fixes that issue by only displaying the buffer once
and doing it with
pop-to-buffer, which will reuse a window if italready displays the buffer.