fix(management_api): decode organization connections as plain objects - #63
Open
dtoxvanilla1991 wants to merge 1 commit into
Open
fix(management_api): decode organization connections as plain objects#63dtoxvanilla1991 wants to merge 1 commit into
dtoxvanilla1991 wants to merge 1 commit into
Conversation
GetConnectionsResponse.Connections (used by GetOrganizationConnections
and GetConnections) decoded each array entry as Connection, the
envelope type for a single-connection response ({code, message,
connection: {...}}). The Kinde API returns plain connection objects
(id, name, display_name, strategy) directly in that array, so every
field ended up empty.
Add fix_organization_connections.go, a go:generate patch step
(matching the existing fix_optstring.go / fix_oneof.go / fix_identity_id.go
convention) that types Connections as []ConnectionConnection and
updates the encoder/decoder accordingly, with no vendored spec.
Reimplements #55's core fix without the unrelated
invitation-code changes (already present on main) or the full vendored-
spec SDK regen. Test files carried over from that PR.
Co-authored-by: BrandtKruger <brandt.kruger087@gmail.com>
|
Warning Review limit reachedNext included review available in 45 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 tasks
victoreronmosele
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #55.
Explain your changes
GetConnectionsResponse.Connections(returned byGetOrganizationConnectionsandGetConnections) decoded each array entry asConnection, the envelope type meant for a single-connection response ({code, message, connection: {...}}). The Kinde API actually returns plain connection objects (id,name,display_name,strategy) directly in that array, so every field ended up empty for callers.This reimplements #55's core fix with a smaller footprint:
ogen --cleanagainst it, regenerating the entire SDK and pulling in unrelated, breaking changes (e.g. aDeleteAPIAppliationScope→DeleteAPIApplicationScoperename, a new required field onCreateApiKeyReq) alongside spec drift against currentmain.fix_organization_connections.go, ago:generatepatch step following the repo's existing convention (fix_optstring.go,fix_oneof.go, and fix(management_api): decode identity_id in CreateUserIdentity response #62'sfix_identity_id.go) that typesConnectionsas[]ConnectionConnectionand updates the encoder/decoder, with no vendored spec and no unrelated regen.authorization_code(GetAuthURLWithInvitation,WithInvitationCode). That's already present onmainvia a separate PR, so it isn't part of this change.Checklist