Skip to content

fix(webview): preserve internal WebView state across rotation (#47) #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jim-daf wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(webview): preserve internal WebView state across rotation (#47) #51

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
010b7bc
fix(webview): preserve internal WebView state across rotation (#47)
jim-daf Apr 25, 2026
89782ab
fix(webview): preserve internal WebView state across rotation (#47)
jim-daf Apr 25, 2026
b42b4b3
fix(webview): preserve internal WebView state across rotation (#47)
jim-daf Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions app/src/main/java/com/kidozh/discuzhub/activities/InternalWebViewActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,13 @@ void configureWebview(){

binding.webview.setWebViewClient(cookieClient);

binding.webview.loadUrl(startURL);

if (savedInstanceState != null) {
// Issue #47: restore the saved WebView state on rotation
// instead of force-reloading the original URL.
binding.webview.restoreState(savedInstanceState);

Copilot AI Apr 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebView.restoreState(...) can return null when it can’t restore the state. In that case, this code skips loadUrl(startURL) and can leave a blank WebView. Capture the return value and fall back to loadUrl(startURL) when restoration fails.

Suggested change
binding.webview.restoreState(savedInstanceState);
if (binding.webview.restoreState(savedInstanceState) == null) {
binding.webview.loadUrl(startURL);
}

Copilot uses AI. Check for mistakes.
} else {
Comment on lines +99 to +103

Copilot AI Apr 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

savedInstanceState is referenced inside configureWebview() but that method doesn’t have a Bundle parameter and there’s no field with that name, so this won’t compile. Pass the savedInstanceState from onCreate() into configureWebview(Bundle) (or store it in a field) and use that value here.

Copilot uses AI. Check for mistakes.
binding.webview.loadUrl(startURL);
}
Comment on lines +99 to +105

Copilot AI Apr 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code restores WebView state on rotation, but this class currently doesn’t override onSaveInstanceState() to call binding.webview.saveState(outState). Without saving the WebView snapshot, restoreState(savedInstanceState) will typically restore nothing. Add onSaveInstanceState() and save the WebView state into the bundle.

Copilot uses AI. Check for mistakes.


}
Expand Down
Loading