Skip to content

16 fix enemy patrol - #56

Draft
Pichun wants to merge 12 commits into
mainfrom
16-fix-enemy-patrol
Draft

16 fix enemy patrol#56
Pichun wants to merge 12 commits into
mainfrom
16-fix-enemy-patrol

Conversation

@Pichun

@Pichun Pichun commented Nov 9, 2024

Copy link
Copy Markdown
Collaborator

Fixed patrol and created a new scene where enemy moves on a certain given path that can be changed for each enemy

@Pichun Pichun linked an issue Nov 9, 2024 that may be closed by this pull request
Comment thread project.godot

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file probably doesn't need to be changed

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange cause i did not touched it (godot seems to do funky stuff), i'll do a pull from main to solve it

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can probably be placed in entities/enemy/ instead of common

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, i'll place it there

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a system specific binary -- shouldn't be added

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, did not touched it (godot seems to do funky stuff), i'll do a pull from main to solve it

@avivajpeyi

Copy link
Copy Markdown
Contributor

So unfortunately this isn't working well with the other enemy states.

I think that the enemy patrol might need to be hacked on here:
https://github.com/kickflip-games/github_game_off_2024/blob/main/entities/enemy/states/patrol.gd

This will allow the patrol-state to work well with the idle, alert, shooting states

@avivajpeyi avivajpeyi mentioned this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix enemy patrol

2 participants