[DoRA] Add serialization and integration tests for DoRA - #23386
Draft
buildwithsuhana wants to merge 1 commit into
Draft
[DoRA] Add serialization and integration tests for DoRA#23386buildwithsuhana wants to merge 1 commit into
buildwithsuhana wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a new unit test test_h5_io_store_dora to verify saving and loading DoRA weights using H5IOStore. However, the test calls enable_dora and accesses DoRA-related attributes on the Dense layer, which are not currently implemented and will cause an AttributeError. Additionally, the H5IOStore opened in read mode is not closed, which could lead to an unreleased file handle.
buildwithsuhana
force-pushed
the
dora-integration
branch
from
August 3, 2026 14:25
94c6db2 to
6e79649
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensures that DoRA-enabled layers are fully integrated into the Keras ecosystem, focusing on model persistence.
Contributor Agreement
Please review our AI-Assisted Contribution Policy and check all boxes below before submitting your PR for review:
Note: Failing to adhere to this agreement may result in your future PRs no longer being reviewed.