Replace jQuery's $.proxy() with modern JavaScript alternatives - #4348
Open
markvantilburg wants to merge 6 commits into
Open
Replace jQuery's $.proxy() with modern JavaScript alternatives#4348markvantilburg wants to merge 6 commits into
markvantilburg wants to merge 6 commits into
Conversation
Replace 16 total instances of $.proxy(): 10 instances → method.bind(context) (constructor method bindings) 6 instances → (e) => method(arg, e) (event handlers with arguments) fixes: kenwheeler#4339
markvantilburg
marked this pull request as draft
November 14, 2025 13:21
method dragHandler - is NOT DEFINED in the file
markvantilburg
marked this pull request as ready for review
November 14, 2025 13:23
Contributor
Author
|
@ahmadalfy can you merge this? I had to remove this since the method is not in the file |
- fix remove cursor pointer on .draggable
…it. IE11 also supports WOFF.
Collaborator
|
@markvantilburg what's the status of this? Do we need to merge it? |
Contributor
Author
|
@ahmadalfy You should be able to merge this. I could not split this on the website the .js change changes the .proxy. The css changes remove "eot" fonts that are long time obsolete. And a fix in duplicate styles. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace 16 total instances of $.proxy():
10 instances → method.bind(context) (constructor method bindings) 6 instances → (e) => method(arg, e) (event handlers with arguments)
fixes: #4339