fix: null-check getLABEL() in StructMapValidator to prevent NPE on unlabelled divs#379
Open
luis100 wants to merge 1 commit into
Open
fix: null-check getLABEL() in StructMapValidator to prevent NPE on unlabelled divs#379luis100 wants to merge 1 commit into
luis100 wants to merge 1 commit into
Conversation
…Validator Fixes NullPointerException in validateCSIP88 (and 9 other methods) when a CSIP <div> or <structMap> element has no LABEL attribute. LABEL is optional in the METS schema, so packages without a representations folder (metadata-only SIPs) could crash the entire validation run instead of producing a report. Fixes #378 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y4iKxBwBcXisaP7MJVJ6VN
dosubot
Bot
added
size:S
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #378
StructMapValidator.validateCSIP88(and 9 other methods in the same class) calledgetLABEL().equals(...)orgetLABEL().matches(...)without a null guard, crashing with aNullPointerExceptionwhen a<structMap>or<div>element has noLABELattribute.LABELis optional in the METS schema, so metadata-only / no-representations packages are valid inputs that previously aborted the entire validation run with no report produced.getLABEL() != null &&to match the pattern already used consistently elsewhere in the same file.Test plan
mvn compile— cleanmvn test(25 tests) — all pass🤖 Generated with Claude Code
https://claude.ai/code/session_01Y4iKxBwBcXisaP7MJVJ6VN