Skip to content

Allow specifying ingress.tls.host if it is different from ingress.host#63

Open
vitaliyf wants to merge 5 commits into
kafbat:mainfrom
vitaliyf:main
Open

Allow specifying ingress.tls.host if it is different from ingress.host#63
vitaliyf wants to merge 5 commits into
kafbat:mainfrom
vitaliyf:main

Conversation

@vitaliyf
Copy link
Copy Markdown

@vitaliyf vitaliyf commented Feb 23, 2026

This is needed when using wildcard certificates, for example this set of values:

ingress:
  enabled: true
  host: kafbat-ui.example.com
  tls:
    enabled: true
    host: "*.example.com"
    secretName: tls-wildcard-example-com

will generate:

apiVersion: networking.k8s.io/v1
kind: Ingress
spec:
  tls:
    - hosts:
        - "*.example.com"
      secretName: tls-wilcard-example-com
  ...etc...

Summary by CodeRabbit

  • New Features
    • Added an optional TLS host setting for Kafka-UI Helm charts. You can specify a separate hostname for TLS certificates distinct from the ingress host; if left empty it falls back to the existing ingress host. Applies only when TLS is enabled.
  • Chores
    • Helm chart version bumped to 1.6.5.

Review Change Stack

@vitaliyf vitaliyf requested a review from a team as a code owner February 23, 2026 02:41
@Haarolean
Copy link
Copy Markdown
Member

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 26, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: caf68209-b92d-4041-be0a-6f09ae226a03

📥 Commits

Reviewing files that changed from the base of the PR and between 564ef2f and 4fb922d.

📒 Files selected for processing (2)
  • charts/kafka-ui/Chart.yaml
  • charts/kafka-ui/values.yaml
✅ Files skipped from review due to trivial changes (1)
  • charts/kafka-ui/Chart.yaml

📝 Walkthrough

Walkthrough

Added a new Helm value ingress.tls.host for Kafka-UI (defaults to ingress.host when unset); the ingress template now uses this TLS host value and the change is documented in CONFIGURATION.md. Chart version bumped to 1.6.5.

Changes

Ingress TLS Host Configuration

Layer / File(s) Summary
Values and template update
charts/kafka-ui/values.yaml, charts/kafka-ui/templates/ingress.yaml, charts/kafka-ui/Chart.yaml, charts/kafka-ui/CONFIGURATION.md
Adds ingress.tls.host: "" to values.yaml and documents it; updates ingress template to render TLS hosts from .Values.ingress.tls.host with fallback to .Values.ingress.host (quoted); bumps chart version to 1.6.5.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐇 I hopped through charts and values neat,
A TLS host now takes its seat,
If blank, it softly falls in line,
Using ingress.host — all fine,
A tiny bump, the chart's complete.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding support for a separate ingress.tls.host parameter distinct from ingress.host, which is the primary purpose of all changes across the four modified files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@charts/kafka-ui/values.yaml`:
- Around line 249-250: Fix the typo in the parameter description for
ingress.tls.host by replacing both occurrences of "ingess" and "ingess.host"
with "ingress" and "ingress.host" respectively in the values.yaml entry for
ingress.tls.host, then regenerate CONFIGURATION.md so the docs and the values
file stay aligned; target the comment text that mentions "ingess"/"ingess.host"
and update it to read "ingress"/"ingress.host".
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: aef3f135-1646-438c-af7f-8265aca28a55

📥 Commits

Reviewing files that changed from the base of the PR and between 9883533 and 502ae4c.

📒 Files selected for processing (3)
  • charts/kafka-ui/CONFIGURATION.md
  • charts/kafka-ui/templates/ingress.yaml
  • charts/kafka-ui/values.yaml

Comment thread charts/kafka-ui/values.yaml Outdated
Copy link
Copy Markdown
Member

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address coderabbit comments

This is needed when using wildcard certificates, for example this set of values:

```
ingress:
  enabled: true
  host: kafbat-ui.example.com
  tls:
    enabled: true
    secretName: tls-wildcard-example-com
    host: "*.example.com"
```

will generate:

```yaml
apiVersion: networking.k8s.io/v1
kind: Ingress
spec:
  tls:
    - hosts:
        - "*.example.com"
      secretName: tls-wilcard-example-com
```
@vitaliyf vitaliyf requested a review from Haarolean April 9, 2026 02:02
@Haarolean
Copy link
Copy Markdown
Member

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 9, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@Haarolean Haarolean enabled auto-merge (squash) April 14, 2026 07:20
auto-merge was automatically disabled May 21, 2026 14:03

Head branch was pushed to by a user without write access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants