Allow specifying ingress.tls.host if it is different from ingress.host#63
Allow specifying ingress.tls.host if it is different from ingress.host#63vitaliyf wants to merge 5 commits into
Conversation
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdded a new Helm value ChangesIngress TLS Host Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@charts/kafka-ui/values.yaml`:
- Around line 249-250: Fix the typo in the parameter description for
ingress.tls.host by replacing both occurrences of "ingess" and "ingess.host"
with "ingress" and "ingress.host" respectively in the values.yaml entry for
ingress.tls.host, then regenerate CONFIGURATION.md so the docs and the values
file stay aligned; target the comment text that mentions "ingess"/"ingess.host"
and update it to read "ingress"/"ingress.host".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: aef3f135-1646-438c-af7f-8265aca28a55
📒 Files selected for processing (3)
charts/kafka-ui/CONFIGURATION.mdcharts/kafka-ui/templates/ingress.yamlcharts/kafka-ui/values.yaml
Haarolean
left a comment
There was a problem hiding this comment.
please address coderabbit comments
This is needed when using wildcard certificates, for example this set of values:
```
ingress:
enabled: true
host: kafbat-ui.example.com
tls:
enabled: true
secretName: tls-wildcard-example-com
host: "*.example.com"
```
will generate:
```yaml
apiVersion: networking.k8s.io/v1
kind: Ingress
spec:
tls:
- hosts:
- "*.example.com"
secretName: tls-wilcard-example-com
```
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Head branch was pushed to by a user without write access
This is needed when using wildcard certificates, for example this set of values:
will generate:
Summary by CodeRabbit