Skip to content

[codex] skip request validator when disabled - #34

Merged
k-kinzal merged 1 commit into
mainfrom
codex/skip-request-validator-when-disabled
Jul 4, 2026
Merged

[codex] skip request validator when disabled#34
k-kinzal merged 1 commit into
mainfrom
codex/skip-request-validator-when-disabled

Conversation

@k-kinzal

@k-kinzal k-kinzal commented Jul 4, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes request handling so disabling request validation actually prevents the request validator from running.

Root Cause

Interceptor::resolveOperation() still called Validator::validateRequest() when request validation was disabled, then swallowed ValidationException. That meant invalid requests could still pay validation cost, and response validation could be skipped because no operation address was available.

Changes

  • Resolve OperationInfo from the schema lookup before operation address resolution.
  • Only call the request validator when request validation is enabled.
  • Build an OperationAddress from the matched operation when request validation is disabled so response validation still works.
  • Add a regression test for response validation with request validation disabled.

Validation

  • composer test
  • composer lint

@k-kinzal
k-kinzal marked this pull request as ready for review July 4, 2026 16:08
@k-kinzal
k-kinzal merged commit 277085c into main Jul 4, 2026
57 checks passed
@k-kinzal
k-kinzal deleted the codex/skip-request-validator-when-disabled branch July 4, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant