Skip to content

feat(pie-textarea): DSW-3900 Add aria prop #3021

Closed
KatarinaNeskovic wants to merge 3 commits into
mainfrom
dsw-3900-pie-textarea-expose-aria-label
Closed

feat(pie-textarea): DSW-3900 Add aria prop #3021
KatarinaNeskovic wants to merge 3 commits into
mainfrom
dsw-3900-pie-textarea-expose-aria-label

Conversation

@KatarinaNeskovic

@KatarinaNeskovic KatarinaNeskovic commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Describe your changes (can list changeset entries if preferable)

This PR adds aria prop to the pie-textarea. Browser tests are added. Testing in Aperture was done locally. Existing draft Aperture PR wasn't updated with the prop change to avoid pushing changes for each prop test.

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@KatarinaNeskovic
KatarinaNeskovic requested a review from a team as a code owner July 14, 2026 13:33
@changeset-bot

changeset-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 743859e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@justeattakeaway/pie-textarea Minor
@justeattakeaway/pie-storybook Minor
@justeattakeaway/pie-webc Patch
@justeattakeaway/pie-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@KatarinaNeskovic

Copy link
Copy Markdown
Contributor Author

/test-aperture

@pie-design-system-app

Copy link
Copy Markdown
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-app

Copy link
Copy Markdown
Contributor

@KatarinaNeskovic Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/pie-textarea@0.0.0-snapshot-release-20260714145655 --mode=update-lockfile
yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20260714145655 --mode=update-lockfile

Then finally:

yarn install

@pie-design-system-app

Copy link
Copy Markdown
Contributor

🚀 Aperture PR created: justeattakeaway/pie-aperture#522

App deployments will appear under the Deployments section of this PR shortly!

Updated 14 Jul 2026, 15:00 UTC · PIE @ d1129d8 · workflow run

@KatarinaNeskovic
KatarinaNeskovic force-pushed the dsw-3900-pie-textarea-expose-aria-label branch from d1129d8 to 0839b38 Compare July 15, 2026 13:20
@pie-design-system-app

Copy link
Copy Markdown
Contributor



Fails
🚫 You have unchecked checklist items outside the "Not-applicable Checklist items" section.

Please ensure all unchecked checkboxes are moved to the appropriate section.

🚫 You have unchecked checklist items in Reviewer 1's section.

Please ensure all items are addressed before approval.

🚫 You have unchecked checklist items in Reviewer 2's section.

Please ensure all items are addressed before approval.

Generated by 🚫 dangerJS against 743859e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant