Skip to content

feat(pie-textarea): DSW-3890 Add Resize None#2991

Merged
KatarinaNeskovic merged 12 commits into
mainfrom
dsw-3890-textarea-resize-none
Jul 8, 2026
Merged

feat(pie-textarea): DSW-3890 Add Resize None#2991
KatarinaNeskovic merged 12 commits into
mainfrom
dsw-3890-textarea-resize-none

Conversation

@KatarinaNeskovic

@KatarinaNeskovic KatarinaNeskovic commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Describe your changes (can list changeset entries if preferable)

This PR adds resize = "none" as a new prop value to pie-textarea. Includes browser tests, as well as a small logic update to reset inline height when switching from auto to none. Testing in Aperture was done locally. Existing draft Aperture PR wasn't updated with the prop change to avoid pushing changes for each prop test.

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] I have reviewed the Aperture changes (if added)
  • [-] If there are visual test updates, I have reviewed them.

Reviewer 2

  • [-] I have reviewed the PIE Storybook/PIE Docs PR preview.
  • [-] I have verified that all acceptance criteria for this ticket have been completed.
  • [-] I have reviewed the Aperture changes (if added)
  • [-] If there are visual test updates, I have reviewed them.

@KatarinaNeskovic
KatarinaNeskovic requested a review from a team as a code owner July 3, 2026 12:20
@changeset-bot

changeset-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1deed28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@justeattakeaway/pie-textarea Minor
@justeattakeaway/pie-webc Patch
@justeattakeaway/pie-docs Patch
@justeattakeaway/pie-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@KatarinaNeskovic

Copy link
Copy Markdown
Contributor Author

/test-aperture

@pie-design-system-app

Copy link
Copy Markdown
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-app

Copy link
Copy Markdown
Contributor

@KatarinaNeskovic Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/pie-textarea@0.0.0-snapshot-release-20260703122357 --mode=update-lockfile
yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20260703122357 --mode=update-lockfile

Then finally:

yarn install

@pie-design-system-app

pie-design-system-app Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

🚀 Aperture PR updated: justeattakeaway/pie-aperture#516

App deployments will appear under the Deployments section of this PR shortly!

Updated 6 Jul 2026, 14:25 UTC · PIE @ e4ce650 · workflow run

@KatarinaNeskovic
KatarinaNeskovic force-pushed the dsw-3890-textarea-resize-none branch from 417b4ca to e4ce650 Compare July 6, 2026 14:17
@KatarinaNeskovic

Copy link
Copy Markdown
Contributor Author

/test-aperture

@pie-design-system-app

Copy link
Copy Markdown
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-app

Copy link
Copy Markdown
Contributor

@KatarinaNeskovic Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/pie-textarea@0.0.0-snapshot-release-20260706142158 --mode=update-lockfile
yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20260706142158 --mode=update-lockfile

Then finally:

yarn install

@KatarinaNeskovic KatarinaNeskovic self-assigned this Jul 7, 2026
raoufswe
raoufswe previously approved these changes Jul 7, 2026
@KatarinaNeskovic KatarinaNeskovic changed the title feat (pie-textarea) : DSW-3890 Add Resize None Prop Value feat (pie-textarea): DSW-3890 Add Resize None Prop Value Jul 7, 2026
@KatarinaNeskovic KatarinaNeskovic changed the title feat (pie-textarea): DSW-3890 Add Resize None Prop Value feat (pie-textarea) : DSW-3890 Add Resize None Prop Value Jul 7, 2026
@KatarinaNeskovic KatarinaNeskovic changed the title feat (pie-textarea) : DSW-3890 Add Resize None Prop Value feat(pie-textarea) : DSW-3890 Add Resize None Prop Value Jul 7, 2026
@KatarinaNeskovic KatarinaNeskovic changed the title feat(pie-textarea) : DSW-3890 Add Resize None Prop Value feat(pie-textarea) : DSW-3890 Add Resize None Jul 7, 2026
@KatarinaNeskovic KatarinaNeskovic changed the title feat(pie-textarea) : DSW-3890 Add Resize None feat(pie-textarea): DSW-3890 Add Resize None Jul 7, 2026
@KatarinaNeskovic
KatarinaNeskovic requested a review from Copilot July 7, 2026 16:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the pie-textarea component API to support a new resize="none" mode, intended to prevent both user-driven and automatic resizing while keeping the component’s sizing consistent when switching away from resize="auto".

Changes:

  • Added none to the supported resize prop values and updated docs accordingly.
  • Introduced styling for the new resize-none wrapper class.
  • Added browser/component test coverage and Storybook testing matrices for the new resize mode.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
packages/components/pie-textarea/src/defs.ts Adds none to resizeModes and updates prop docs.
packages/components/pie-textarea/src/index.ts Clears inline height when switching to resize="none" (and on related size/rows changes).
packages/components/pie-textarea/src/textarea.scss Adds c-textarea--resize-none styling via CSS variables.
packages/components/pie-textarea/test/component/pie-textarea.spec.ts Adds component tests for resize="none".
packages/components/pie-textarea/README.md Updates public API docs to include resize="none".
apps/pie-storybook/stories/pie-textarea.stories.ts Updates Storybook argType descriptions for the new option.
apps/pie-storybook/stories/testing/pie-textarea.test.stories.ts Expands testing story matrices to include resize="none".
.changeset/textarea-resize-none.md Declares a minor release for the new prop value.

Comment thread packages/components/pie-textarea/README.md
Comment thread packages/components/pie-textarea/src/defs.ts Outdated
Comment thread apps/pie-storybook/stories/pie-textarea.stories.ts Outdated
Comment thread packages/components/pie-textarea/src/textarea.scss Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
KatarinaNeskovic and others added 3 commits July 7, 2026 18:18
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
raoufswe
raoufswe previously approved these changes Jul 8, 2026
@KatarinaNeskovic
KatarinaNeskovic merged commit 27b1abe into main Jul 8, 2026
24 of 25 checks passed
@KatarinaNeskovic
KatarinaNeskovic deleted the dsw-3890-textarea-resize-none branch July 8, 2026 10:31
@pie-design-system-app pie-design-system-app Bot mentioned this pull request Jul 8, 2026
talitha-ferreira-01 pushed a commit that referenced this pull request Jul 14, 2026
* feat(pie-textarea): DSW-3890 add resize none prop value

* feat(pie-textarea): DSW-3890 add tests

* feat(pie-textarea): DSW-3890 set auto height in none mode to respect rows prop

* feat(pie-textarea): DSW-3890 update descriptions for resize=none

* feat(pie-textarea): DSW-3890 update descriptions for resize none option

* feat(pie-textarea): DSW-3890 update defs for resize none option

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Delete space

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* feat(pie-textarea): DSW-3890 update test

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Raouf <raouf.sawehli@justeattakeaway.com>
Grrreidy added a commit that referenced this pull request Jul 15, 2026
* docs(pie-docs): DSW-3951 checkbox updated web docs

* docs(pie-docs): DSW-3951 checkbox updated web and android docs

* docs(pie-docs): DSW-3951 checkbox updated web and android docs

* docs(pie-docs): DSW-3951 checkbox updated web and android docs

* docs(pie-docs): DSW-3951 added changeset

* docs(pie-docs): DSW-3951 added changeset

* feat(pie-list): DSW-4116 plain text list/list-item (#2989)

* feat(pie-css): DSW-4116 mixin for slotted element allowlists

* fix lint

* initial list-item markup and props

* basic list item structure styling

* typograpghy

* add named slots to the scss mixin

* borders

* fix lint

* comment

* compact padding

* fix lint

* icons, fix trailing slot display, flex alignment and lint fixes

* todo readme comments

* handle multiline text and more story demos

* fix lint

* organise stories

* handle avatar padding quirk and disallow large comps in compact mode

* readme and slot policing

* add tests + readme and fix metatext single line alignment

* fix lint

* test scss mixin

* tidy ts

* safari firefox style fix

* display block list-items

* remove slot policing

* apply gap padding to slotted trailing content and metatext instead of text

* rename default story

* no longer reflect props

* classmap

* tidy up css overrides and variable names

* update css

* update alignment override var

* remove requiredpropertyvalue decorator use

* camelCase and boolean bindings

* Version Packages (#3002)

release: release packages with 'latest' tag

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* feat(pie-textarea): DSW-3890 Add Resize None (#2991)

* feat(pie-textarea): DSW-3890 add resize none prop value

* feat(pie-textarea): DSW-3890 add tests

* feat(pie-textarea): DSW-3890 set auto height in none mode to respect rows prop

* feat(pie-textarea): DSW-3890 update descriptions for resize=none

* feat(pie-textarea): DSW-3890 update descriptions for resize none option

* feat(pie-textarea): DSW-3890 update defs for resize none option

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Delete space

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* feat(pie-textarea): DSW-3890 update test

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Raouf <raouf.sawehli@justeattakeaway.com>

* feat(pie-spinner): DSW-4138 support centered prop (#2999)

* feat(pie-spinner): DSW-4138 support centered prop

* fix(pie-spinner): DSW-4138 revert a story

* fix(pie-spinner): DSW-4138 revert a story

* fix(pie-spinner): DSW-4138 update size

* fix(pie-storybook): DSW-4138 use media instead container for responsive story

* fix(pie-spinner): DSW-4138 update prop name

* Version Packages (#3005)

* feat(pie-docs): DSW-3939 fab figma docs migration (#2988)

* feat(pie-docs): DSW-3939 added apps and web docs

* fix(eslint-plugin-snacks-pie-migration): DSW-3939 restore trailing newline

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* docs(pie-docs): DSW-3939 updated FAB web and app docs

* feat(pie-docs): DSW-3939 added changeset for FAB docs

* Update .changeset/sparkly-deer-create.md

Co-authored-by: Fernando de França <448801+fernandofranca@users.noreply.github.com>

---------

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Co-authored-by: T. Ferreira <215656619+talitha-ferreira-01@users.noreply.github.com>
Co-authored-by: Fernando de França <448801+fernandofranca@users.noreply.github.com>

* feat(pie-docs): DSW-4114 update Accordion web page (#3004)

* feat(pie-docs): DSW-4114 update accordion web page

* chore(pie-monorepo): DSW-1234 changeset

* feat(pie-docs): DSW-4114 fix heading level

* feat(pie-docs): DSW-4114 update snapshots

* chore(pie-css): DSW-4137 update pie-tokens version (#3008)

* chore(pie-css): DSW-4137 update pie-tokens version

* chore(pie-css): DSW-4137 fix changesets format

* fix(pie-css): DSW-4137 update css output

* fix(pie-docs): DSW-4137 update tokens

* fix(pie-docs): DSW-4137 update tokens

---------

Co-authored-by: Raouf <abdulraoufswehli58@gmail.com>

* Version Packages (#3006)

* feat(pie-docs): DSW-3941 list item radio figma docs migration (#2973)

* feat(pie-docs): DSW-3941 list item radio figma docs migration

* feat(pie-docs): DSW-3941 added list item docs

* feat(pie-docs): DSW-3941 added expected routes

* feat(pie-docs): DSW-3941 added android docs

* feat(pie-docs): DSW-3941 added ios docs updated web

* feat(pie-docs): DSW-3941 small updates across docs

* feat(pie-docs): DSW-3941 small updates across pattern docs added new index img

* Create true-waves-flow.md

* feat(pie-docs): DSW-3941 added contents links section to apps list item docs

* Added missing notification to android.md

* Added missing notification to ios.md

* Update .changeset/true-waves-flow.md

Co-authored-by: Raouf <raouf.sawehli@justeattakeaway.com>

---------

Co-authored-by: Talitha Ferreira <talitha-ferreira-01@users.noreply.github.com>
Co-authored-by: Raouf <raouf.sawehli@justeattakeaway.com>

* feat(pie-accordion): DSW-4142 add CSS variable for accordion border radius (#3010)

* chore(pie-monorepo): DSW-1234 changeset

* feat(pie-accordion): DSW-4142 accordion radius add docs, stories and css variable

* feat(pie-accordion): DSW-4142 host radius, overflow: hidden + pie-css.focus mixin

* feat(pie-accordion): DSW-4142 add radius test story with background

* feat(pie-accordion): DSW-4142 improve readability

* feat(pie-accordion): DSW-4142 improve stories consistency

* feat(pie-accordion): DSW-4142 remove redundant css

* feat(pie-icons): Update icons from pie-iconography (#3011)

feat(pie-icons): update icons

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Version Packages (#3009)

release: release packages with 'latest' tag

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* chore(pie-accordion): DSW-4157 promote pie-accordion to beta status (#3015)

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

* deps(npm): Bump vitest from 4.1.9 to 4.1.10 in the vitest group (#3012)

Bumps the vitest group with 1 update: [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest).


Updates `vitest` from 4.1.9 to 4.1.10
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md)
- [Commits](https://github.com/vitest-dev/vitest/commits/v4.1.10/packages/vitest)

---
updated-dependencies:
- dependency-name: vitest
  dependency-version: 4.1.10
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: vitest
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Fernando de França <448801+fernandofranca@users.noreply.github.com>

* feat(eslint-plugin-snacks-pie-migration): Update eslint rules for PIE migration (#3016)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ben Siggery <14013357+siggerzz@users.noreply.github.com>

* Version Packages (#3017)

release: release packages with 'latest' tag

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* feat(pie-docs): DSW-3951 added snapshot routes

* feat(pie-docs): DSW-3951 removed structure section

* Update apps/pie-docs/src/components/checkbox/ios/ios.md

Co-authored-by: Fernando de França <448801+fernandofranca@users.noreply.github.com>

* Update apps/pie-docs/src/components/checkbox/android/android.md

Co-authored-by: Fernando de França <448801+fernandofranca@users.noreply.github.com>

* docs(pie-docs): DSW-3951 checkbox Android docs update

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: T. Ferreira <215656619+talitha-ferreira-01@users.noreply.github.com>
Co-authored-by: Jamie Maguire <jamieolivermaguire@googlemail.com>
Co-authored-by: pie-design-system-app[bot] <157033764+pie-design-system-app[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Katarina Neskovic <134618695+KatarinaNeskovic@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Raouf <raouf.sawehli@justeattakeaway.com>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Co-authored-by: Fernando de França <448801+fernandofranca@users.noreply.github.com>
Co-authored-by: maledr5 <maledr5@hotmail.es>
Co-authored-by: Raouf <abdulraoufswehli58@gmail.com>
Co-authored-by: Talitha Ferreira <talitha-ferreira-01@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ben Siggery <14013357+siggerzz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants