Skip to content

fix(pie-switch): DSW-4058 annouce external labels properly by screen readers in Safari#2985

Merged
raoufswe merged 18 commits into
mainfrom
dsw-4058-switch-labels
Jul 3, 2026
Merged

fix(pie-switch): DSW-4058 annouce external labels properly by screen readers in Safari#2985
raoufswe merged 18 commits into
mainfrom
dsw-4058-switch-labels

Conversation

@raoufswe

@raoufswe raoufswe commented Jul 1, 2026

Copy link
Copy Markdown
Member

Describe your changes (can list changeset entries if preferable)

  • Added a synthetic label for pie-switch when used in Safari. This is a workaround for a WebKit bug where the component was not announced by screen readers when linked to external labels.
  • Fixed a flickering issue when pie-checkbox and pie-radio are rendered in SSR. Aperture Next.js -> Prod | Feature

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.


Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2

  • [-] I have reviewed the PIE Storybook/PIE Docs PR preview.
  • [-] I have verified that all acceptance criteria for this ticket have been completed.
  • [-] I have reviewed the Aperture changes (if added)
  • [-] If there are visual test updates, I have reviewed them.

@raoufswe
raoufswe requested a review from a team as a code owner July 1, 2026 14:42
@changeset-bot

changeset-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5f62681

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@justeattakeaway/pie-webc-core Minor
@justeattakeaway/pie-switch Patch
@justeattakeaway/pie-button Patch
@justeattakeaway/pie-storybook Patch
@justeattakeaway/pie-accordion Patch
@justeattakeaway/pie-assistive-text Patch
@justeattakeaway/pie-avatar Patch
@justeattakeaway/pie-breadcrumb Patch
@justeattakeaway/pie-card Patch
@justeattakeaway/pie-checkbox-group Patch
@justeattakeaway/pie-checkbox Patch
@justeattakeaway/pie-chip Patch
@justeattakeaway/pie-cookie-banner Patch
@justeattakeaway/pie-data-table Patch
@justeattakeaway/pie-divider Patch
@justeattakeaway/pie-form-label Patch
@justeattakeaway/pie-icon-button Patch
@justeattakeaway/pie-link Patch
@justeattakeaway/pie-list Patch
@justeattakeaway/pie-lottie-player Patch
@justeattakeaway/pie-modal Patch
@justeattakeaway/pie-notification Patch
@justeattakeaway/pie-radio-group Patch
@justeattakeaway/pie-radio Patch
@justeattakeaway/pie-select Patch
@justeattakeaway/pie-spinner Patch
@justeattakeaway/pie-tabs Patch
@justeattakeaway/pie-tag Patch
@justeattakeaway/pie-text-input Patch
@justeattakeaway/pie-textarea Patch
@justeattakeaway/pie-thumbnail Patch
@justeattakeaway/pie-toast-provider Patch
@justeattakeaway/pie-toast Patch
@justeattakeaway/pie-icons-webc Patch
@justeattakeaway/pie-webc Patch
@justeattakeaway/pie-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@raoufswe

This comment was marked as off-topic.

@pie-design-system-app

This comment was marked as outdated.

@pie-design-system-app

This comment was marked as outdated.

@raoufswe

This comment was marked as outdated.

@pie-design-system-app

This comment was marked as outdated.

@pie-design-system-app

This comment was marked as outdated.

@raoufswe

This comment was marked as outdated.

@raoufswe

This comment was marked as outdated.

@pie-design-system-app

This comment was marked as outdated.

@pie-design-system-app

This comment was marked as outdated.

@raoufswe

This comment was marked as outdated.

@pie-design-system-app

This comment was marked as outdated.

@pie-design-system-app

This comment was marked as outdated.

@raoufswe raoufswe changed the title fix(pie-switch): DSW-4058 annouce external labels properly by screen … fix(pie-switch): DSW-4058 annouce external labels properly by screen readers in Safari Jul 1, 2026
@raoufswe

This comment was marked as outdated.

@pie-design-system-app

This comment was marked as outdated.

@pie-design-system-app

This comment was marked as outdated.

@raoufswe

This comment was marked as outdated.

@pie-design-system-app

This comment was marked as outdated.

@pie-design-system-app

This comment was marked as outdated.

@raoufswe

This comment was marked as outdated.

@pie-design-system-app

This comment was marked as outdated.

@pie-design-system-app

This comment was marked as outdated.

@raoufswe

raoufswe commented Jul 3, 2026

Copy link
Copy Markdown
Member Author

/test-aperture

@pie-design-system-app

Copy link
Copy Markdown
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-app

Copy link
Copy Markdown
Contributor

@raoufswe Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/pie-accordion@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-assistive-text@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-avatar@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-breadcrumb@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-button@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-card@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-checkbox@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-checkbox-group@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-chip@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-cookie-banner@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-data-table@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-divider@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-form-label@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-icon-button@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-link@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-list@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-lottie-player@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-modal@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-notification@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-radio@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-radio-group@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-select@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-spinner@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-switch@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-tabs@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-tag@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-text-input@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-textarea@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-thumbnail@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-toast@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-toast-provider@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-webc-core@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile
yarn up @justeattakeaway/pie-icons-webc@0.0.0-snapshot-release-20260703135516 --mode=update-lockfile

Then finally:

yarn install

@raoufswe
raoufswe merged commit 1926dd6 into main Jul 3, 2026
100 of 107 checks passed
@raoufswe
raoufswe deleted the dsw-4058-switch-labels branch July 3, 2026 14:47
@pie-design-system-app pie-design-system-app Bot mentioned this pull request Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants