feat(pie-switch): DSW-4019 bind the checked prop correctly and add missing form behaviours#2963
Open
raoufswe wants to merge 12 commits into
Open
feat(pie-switch): DSW-4019 bind the checked prop correctly and add missing form behaviours#2963raoufswe wants to merge 12 commits into
raoufswe wants to merge 12 commits into
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
raoufswe
commented
Jun 25, 2026
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
Member
Author
|
/snapit |
Contributor
|
Starting a new snapshot build. You can view the logs here. |
Contributor
|
@raoufswe Your snapshots have been published to npm! Test the snapshots by updating your Note If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts. yarn up @justeattakeaway/pie-cookie-banner@0.0.0-snapshot-release-20260626172928 --mode=update-lockfileyarn up @justeattakeaway/pie-switch@0.0.0-snapshot-release-20260626172928 --mode=update-lockfileyarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20260626172928 --mode=update-lockfileThen finally: yarn install |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes (can list changeset entries if preferable)
defaultCheckedprop and form rest logic<div>as the parent wrapper when the label prop isn’t provided. This avoids nested<label>elements when consumers wrap the component with an external label, which is an invalid HTML patternAuthor Checklist (complete before requesting a review, do not delete any)
PIE Storybook/PIE DocsPR preview./test-aperturecommand.Not-applicable Checklist items
Please move any Author checklist items that do not apply to this pull request here.
Reviewer checklists (complete before approving)
Mark items as
[-] N/Aif not applicable.Reviewer 1
PIE Storybook/PIE DocsPR preview.Reviewer 2
PIE Storybook/PIE DocsPR preview.