Skip to content

feat(pie-textarea): DSW-3891 Add rows prop#2962

Open
KatarinaNeskovic wants to merge 3 commits into
mainfrom
dsw-3891-textarea-rows-prop
Open

feat(pie-textarea): DSW-3891 Add rows prop#2962
KatarinaNeskovic wants to merge 3 commits into
mainfrom
dsw-3891-textarea-rows-prop

Conversation

@KatarinaNeskovic

@KatarinaNeskovic KatarinaNeskovic commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Please click the Preview tab and select a different PR template if your change isn't for an existing web component.

PIE Docs Template
New Web Component Template

═══════════════════════════════════════════════════════════

Describe your changes (can list changeset entries if preferable)

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.


Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@KatarinaNeskovic KatarinaNeskovic requested a review from a team as a code owner June 23, 2026 15:42
@changeset-bot

changeset-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0da0c6e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@justeattakeaway/pie-textarea Minor
@justeattakeaway/pie-webc Patch
@justeattakeaway/pie-docs Patch
@justeattakeaway/pie-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@KatarinaNeskovic KatarinaNeskovic changed the title DSW-3891: Textarea Rows Prop feat(pie-textarea): DSW-3891 Add rows prop Jun 23, 2026
@pie-design-system-app pie-design-system-app Bot temporarily deployed to storybook-testing-pr-2962 June 23, 2026 15:47 Inactive
@KatarinaNeskovic

Copy link
Copy Markdown
Contributor Author

/test-aperture

@pie-design-system-app

Copy link
Copy Markdown
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-app pie-design-system-app Bot requested a deployment to storybook-testing-pr-2962 June 23, 2026 15:59 Pending
@KatarinaNeskovic KatarinaNeskovic force-pushed the dsw-3891-textarea-rows-prop branch from afb58e6 to 0da0c6e Compare June 23, 2026 16:00
@KatarinaNeskovic KatarinaNeskovic changed the title feat(pie-textarea): DSW-3891 Add rows prop feat(pie-textarea) : DSW-3891 Add rows prop Jun 23, 2026
@pie-design-system-app

Copy link
Copy Markdown
Contributor

@KatarinaNeskovic Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/pie-textarea@0.0.0-snapshot-release-20260623160452 --mode=update-lockfile
yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20260623160452 --mode=update-lockfile

Then finally:

yarn install

@pie-design-system-app

Copy link
Copy Markdown
Contributor

🚀 Aperture PR created: justeattakeaway/pie-aperture#507

App deployments will appear under the Deployments section of this PR shortly!

Updated 23 Jun 2026, 16:07 UTC · PIE @ 0da0c6e · workflow run

@pie-design-system-app

Copy link
Copy Markdown
Contributor



Fails
🚫 You have unchecked checklist items outside the "Not-applicable Checklist items" section.

Please ensure all unchecked checkboxes are moved to the appropriate section.

🚫 You have unchecked checklist items in Reviewer 1's section.

Please ensure all items are addressed before approval.

🚫 You have unchecked checklist items in Reviewer 2's section.

Please ensure all items are addressed before approval.

Generated by 🚫 dangerJS against 0da0c6e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant