Dsw 3992 light dom#2906
Conversation
🦋 Changeset detectedLatest commit: 53e7e0f The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
| /// :host { | ||
| /// @include radio-slotted-input-base('input[type="radio"]'); | ||
| /// } | ||
| @mixin radio-slotted-input-base($selector) { |
There was a problem hiding this comment.
This is a really nice pattern 😄
Q – could this use a default selector if it were to be radio specific?
@mixin radio-slotted-input-base($selector: 'input[type="radio"]') {and then called just with:
@include radio-slotted-input-base();Or could even set it as an optional variable, so that all the mixins can make use of it, and it be overridden by the user if they needed to:
$pRadioSelector: 'input[type="radio"]' !default;
@mixin radio-slotted-input-base() {
::slotted(#{$pRadioSelector}) {
…
}
}There was a problem hiding this comment.
yeah you totally could add a default value! both are quite smooth ideas
ignore for now please