Skip to content

Dsw 3992 light dom#2906

Open
jamieomaguire wants to merge 5 commits into
mainfrom
dsw-3992-light-dom
Open

Dsw 3992 light dom#2906
jamieomaguire wants to merge 5 commits into
mainfrom
dsw-3992-light-dom

Conversation

@jamieomaguire

Copy link
Copy Markdown
Contributor

ignore for now please

@jamieomaguire jamieomaguire requested a review from a team as a code owner June 4, 2026 07:59
@changeset-bot

changeset-bot Bot commented Jun 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 53e7e0f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@justeattakeaway/pie-lite-radio Minor
@justeattakeaway/pie-webc Minor
@justeattakeaway/pie-storybook Minor
@justeattakeaway/pie-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pie-design-system-app

Copy link
Copy Markdown
Contributor
Fails
🚫

PR Title Validation Failed

The PR title should follow the same convention used for commits, e.g.:
type(scope): TICKET-123 title where TICKET-123 is a valid ticket ID.

Note: Ticket IDs cannot be all zeros (e.g. DSW-000 is not allowed).

Current title: Dsw 3992 light dom

Generated by 🚫 dangerJS against 53e7e0f

/// :host {
/// @include radio-slotted-input-base('input[type="radio"]');
/// }
@mixin radio-slotted-input-base($selector) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really nice pattern 😄

Q – could this use a default selector if it were to be radio specific?

@mixin radio-slotted-input-base($selector: 'input[type="radio"]') {

and then called just with:

@include radio-slotted-input-base();

Or could even set it as an optional variable, so that all the mixins can make use of it, and it be overridden by the user if they needed to:

$pRadioSelector: 'input[type="radio"]' !default;

@mixin radio-slotted-input-base() {
	::slotted(#{$pRadioSelector}) {
        …
    }
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah you totally could add a default value! both are quite smooth ideas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants