-
-
Notifications
You must be signed in to change notification settings - Fork 732
feat(jspsych): add record_session option for high-fidelity replay capture #3661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jodeleeuw
wants to merge
18
commits into
main
Choose a base branch
from
claude/add-hifi-data-recording-jfxSP
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
00b1e3d
feat(jspsych): add record_session option for high-fidelity replay cap…
claude 5501e53
feat(jspsych): capture scroll events in session recording
claude d907630
fix(jspsych): preserve user-set Math.random; harden cleanup paths
claude 9217f6a
refactor(jspsych): make SessionRecorder reusable across runs
claude d396102
refactor(jspsych): move rng_calls to session scope; drop unused idToNode
claude 80a290a
refactor(jspsych): make DOM the single source of truth for replay
claude 4e2f79a
test(jspsych): cover multi-trial, viewport, focus, media, and abort p…
claude 6748043
Merge remote-tracking branch 'origin/main' into claude/add-hifi-data-…
claude 45be441
ci: re-trigger preview-publish to verify PR comment posting
claude d360fcb
docs: add session recording schema reference
claude dc21625
fix(jspsych): capture document stylesheets so replay preserves CSS
claude 2495e0a
feat(jspsych): track <head> stylesheet changes during replay capture
claude 61e35b5
feat(jspsych): record form-state changes for survey replay fidelity
claude 4b2445f
feat(jspsych): capture <canvas> pixel state for replay fidelity
claude 7998445
feat(jspsych): widen initial_dom into a layout spine for replay fidelity
claude c7feb4a
feat(jspsych): canvas region-diff snapshots and draw-detection for re…
jodeleeuw 3e94add
fix(jspsych): scope mouse/touch listeners to window so off-content ac…
jodeleeuw 7d4df31
feat(jspsych): add getSessionRecordingCompressed() returning a gzip Blob
jodeleeuw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run()starts/stops the session recorder, but the stop/unpatch cleanup won't run iftimeline.run()or the user-providedon_finishcallback throws/rejects. Since recording wrapsMath.randomand attaches global listeners, this can leak patched state beyond the experiment.Consider wrapping the body of
run()in atry { ... } finally { ... }that always callsthis.sessionRecorder?.stop("finished")(or an appropriate reason) and removes interaction listeners, even on error.